Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-519] grants improvements #1412

Merged
merged 3 commits into from
Dec 18, 2024
Merged

[SD-519] grants improvements #1412

merged 3 commits into from
Dec 18, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Dec 16, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-519

What I did

  • Update grants listing sorting
  • Update status display
  • Fixes ongoing grant showing when using the open filter
  • Remove updated date

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry
feat(@dpc-sdp/ripple-tide-grant): update grants listing sort and stat…
28d0589 
…us display

adds better grants sorting, fixes some ongoing grants showing when using the open filter, add new clock icon and status labels, remove updated date
@lambry lambry added this to the 2.23.0 milestone Dec 16, 2024
@lambry lambry self-assigned this Dec 16, 2024
@cypress Cypress
Copy link

cypress bot commented Dec 16, 2024 •
edited
Loading

ripple-framework    Run #2473

Run Properties:  status check passed Passed #2473  •  git commit 4e4dbedf79: fix(@dpc-sdp/ripple-tide-grant): update formatting test
Project ripple-framework
Branch Review feature/grants-improvements
Run status status check passed Passed #2473
Run duration 10m 43s
Commit git commit 4e4dbedf79: fix(@dpc-sdp/ripple-tide-grant): update formatting test
Committer David Featherston
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 214
View all changes introduced in this branch ↗︎

@lambry lambry marked this pull request as ready for review December 17, 2024 00:04
@lambry lambry merged commit 937003b into release/2.23.0 Dec 18, 2024
6 checks passed
@lambry lambry deleted the feature/grants-improvements branch December 18, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly Awaiting requested review from dylankelly

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @jeffdowdle