Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-180] always set input focus #1413

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[SD-180] always set input focus #1413

merged 1 commit into from
Dec 19, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Dec 19, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-180

What I did

  • fix to always set input focus

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.23.0 milestone Dec 19, 2024
@lambry lambry self-assigned this Dec 19, 2024
@lambry lambry merged commit 824bb99 into release/2.23.0 Dec 19, 2024
12 of 14 checks passed
@lambry lambry deleted the feature/dropdown-combobox branch December 19, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@waitingallday waitingallday waitingallday approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly