Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1544][R20-1547] Add secondary campaign to search listing #873

Merged

Conversation

waitingallday
Copy link
Member

@waitingallday waitingallday commented Sep 28, 2023

Issue: https://digital-vic.atlassian.net/browse/R20-1544

What I did

  • Exported secondary campaign mapping, includes, interface from ripple-tide-landing-page
  • Added secondary campaign mapping, includes, interface to ripple-tide-search search listing

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit cae72da
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6519f6285a03d10008dc20bd

@cypress
Copy link

cypress bot commented Sep 28, 2023

Passing run #746 ↗︎

0 99 0 0 Flakiness 0

Details:

refactor(@dpc-sdp/ripple-tide-search): ♻️ move secondary campaign to righ...
Project: ripple-framework Commit: cae72da6a4
Status: Passed Duration: 07:50 💡
Started: Oct 1, 2023 10:48 PM Ended: Oct 1, 2023 10:56 PM

Review all test suite changes for PR #873 ↗︎

Copy link
Contributor

@jeffdowdle jeffdowdle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about the belowBody slot

@waitingallday waitingallday added this pull request to the merge queue Oct 1, 2023
Merged via the queue into develop with commit 8f1f641 Oct 1, 2023
6 checks passed
@dylankelly dylankelly changed the title [R20-1544] Add secondary campaign to search listing [R20-1544][R20-1547] Add secondary campaign to search listing Oct 18, 2023
@waitingallday waitingallday deleted the feat/r20-1544-search-listing-secondary-campaign branch October 25, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants