Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: 📝 update badges, add tools and frameworks #875

Merged
merged 7 commits into from
Oct 15, 2023
Merged

docs: 📝 update badges, add tools and frameworks #875

merged 7 commits into from
Oct 15, 2023

Conversation

waitingallday
Copy link
Member

Issue:

What I did

  • Removed link to npm
  • Changed circle CI badge to github actions
  • Added some notes about tools and frameworks used in Ripple 2

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday self-assigned this Oct 3, 2023
@netlify
Copy link

netlify bot commented Oct 3, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs ready!

Name Link
🔨 Latest commit 50f52a0
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65249111c7d1f40008a3f7b8
😎 Deploy Preview https://deploy-preview-875--ripple-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Oct 4, 2023 •
edited
Loading

Passing run #787 ↗︎

0 99 0 0 Flakiness 0

Details:

Merge branch 'develop' into task/update-readme-vue3
Project: ripple-framework Commit: 50f52a0978
Status: Passed Duration: 05:11 💡
Started: Oct 9, 2023 11:51 PM Ended: Oct 9, 2023 11:56 PM

Review all test suite changes for PR #875 ↗︎

@waitingallday
Copy link
Member Author

waitingallday commented Oct 9, 2023 •
edited
Loading

Just realised I've hit some kind of limit on markdown render - https://651e1821217e21000880240c--ripple-docs.netlify.app/design-system/develop/usage I'll need to break the Usage page up

Actually it's loading CSS out of order 🙁

Tailwind 🙁

https://github.com/dpc-sdp/ripple-framework/pull/806/files

dylankelly
dylankelly reviewed Oct 15, 2023
View reviewed changes
README.md

### Availability

Note: Ripple 2 will only be hosted on Github Packages, any packages still published to npm are either pre-release or deprecated, and should not be used. Please see the section [Access to Github Packages repos](https://www.ripple.vic.gov.au/design-system/develop/usage#access-to-github-packages-repos) for instructions on how to set up a personal access token, and where to use it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to use new page link

@waitingallday waitingallday added this pull request to the merge queue Oct 15, 2023
Merged via the queue into develop with commit 9b24afa Oct 15, 2023
12 checks passed
@waitingallday waitingallday deleted the task/update-readme-vue3 branch October 25, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@waitingallday waitingallday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waitingallday @dylankelly @jeffdowdle