Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1571] Only render icon if item has text or url #895

Merged
merged 3 commits into from
Oct 17, 2023
Merged

[R20-1571] Only render icon if item has text or url #895

merged 3 commits into from
Oct 17, 2023

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/R20-1571

What I did

  • Added check on list item container to prevent orphaned icon

How to test

  • Added reproduction to storybook (data in the story is technically not possible since the CMS won't allow an item with text or url)

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday self-assigned this Oct 12, 2023
@netlify
Copy link

netlify bot commented Oct 12, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit e2ad244
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/652ddcff47c44c0008b2af36

@cypress
Copy link

cypress bot commented Oct 12, 2023 •
edited
Loading

Passing run #812 ↗︎

0 99 0 0 Flakiness 0

Details:

Merge branch 'develop' into fix/r20-1571-contact-us-default
Project: ripple-framework Commit: e2ad244e40
Status: Passed Duration: 04:39 💡
Started: Oct 17, 2023 1:05 AM Ended: Oct 17, 2023 1:09 AM

Review all test suite changes for PR #895 ↗︎

@waitingallday waitingallday added this pull request to the merge queue Oct 17, 2023
Merged via the queue into develop with commit c31de49 Oct 17, 2023
12 checks passed
@waitingallday waitingallday deleted the fix/r20-1571-contact-us-default branch October 25, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@waitingallday waitingallday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waitingallday @dylankelly @jeffdowdle