Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1586] add check for secondary link in header with CTA #900

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[R20-1586] add check for secondary link in header with CTA #900

merged 1 commit into from
Oct 18, 2023

Conversation

dylankelly
Copy link
Contributor

…eader

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@dylankelly dylankelly self-assigned this Oct 18, 2023
@netlify
Copy link

netlify bot commented Oct 18, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit efe022b
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/652f2dfdb97e1900091cc3dd

@dylankelly dylankelly force-pushed the feature/R20-1586-fix-header-button branch from db1a1e7 to efe022b Compare October 18, 2023 00:59
@cypress
Copy link

cypress bot commented Oct 18, 2023

Passing run #825 ↗︎

0 99 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-ui-core): 🐛 add check for secondary link in header
Project: ripple-framework Commit: efe022b58d
Status: Passed Duration: 07:41 💡
Started: Oct 18, 2023 1:04 AM Ended: Oct 18, 2023 1:12 AM

Review all test suite changes for PR #900 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Oct 18, 2023
Merged via the queue into develop with commit 3b503e0 Oct 18, 2023
@waitingallday waitingallday deleted the feature/R20-1586-fix-header-button branch October 25, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@waitingallday waitingallday waitingallday approved these changes

Assignees

@dylankelly dylankelly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylankelly @waitingallday @jeffdowdle