Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1591] Add rpl-content on timeline container #913

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[R20-1591] Add rpl-content on timeline container #913

merged 1 commit into from
Oct 30, 2023

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/R20-1591

What I did

  • Added .rpl-content to description container in RplTimeline, updated storybook

How to test

  • Storybook

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday self-assigned this Oct 25, 2023
@netlify
Copy link

netlify bot commented Oct 25, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit af1a4c4
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65388e1a3e8b8d000888acaf

@cypress
Copy link

cypress bot commented Oct 25, 2023

Passing run #859 ↗︎

0 99 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-ui-core): 🐛 add rpl-content on container
Project: ripple-framework Commit: af1a4c4e1c
Status: Passed Duration: 05:15 💡
Started: Oct 25, 2023 3:40 AM Ended: Oct 25, 2023 3:45 AM

Review all test suite changes for PR #913 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Oct 30, 2023
Merged via the queue into develop with commit 8623c69 Oct 30, 2023
12 checks passed
@dylankelly dylankelly deleted the fix/r20-1591-timeline-markup branch October 30, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@waitingallday waitingallday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waitingallday @dylankelly @jeffdowdle