Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDPSUP-5960] changed the way sectionId is passed to mapping functions #914

Closed
wants to merge 3 commits into from
Closed

[SDPSUP-5960] changed the way sectionId is passed to mapping functions #914

wants to merge 3 commits into from

Conversation

jeffdowdle
Copy link
Contributor

@jeffdowdle jeffdowdle commented Oct 26, 2023 •
edited
Loading

Issue: SDPSUP-5960

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this Oct 26, 2023
@netlify
Copy link

netlify bot commented Oct 26, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 977cb2c
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/654034cff01e810008b562eb

@cypress
Copy link

cypress bot commented Oct 26, 2023 •
edited
Loading

Passing run #861 ↗︎

0 99 0 0 Flakiness 0

Details:

chore(@dpc-sdp/ripple-tide-api): removed console log
Project: ripple-framework Commit: b90be2ac9d
Status: Passed Duration: 06:59 💡
Started: Oct 26, 2023 3:23 AM Ended: Oct 26, 2023 3:30 AM

Review all test suite changes for PR #914 ↗︎

@dylankelly dylankelly changed the title fix(@dpc-sdp/ripple-tide-api): changed the way sectionId is passed to mapping functions [SDPSUP-5960] changed the way sectionId is passed to mapping functions Oct 29, 2023
@jeffdowdle jeffdowdle closed this Oct 30, 2023
@dylankelly dylankelly deleted the bugfix/SDPSUP-5960 branch August 26, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@waitingallday waitingallday waitingallday approved these changes

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffdowdle @waitingallday @dylankelly