Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new drush command for audit trail logs cleaup #534

Merged
merged 10 commits into from
Dec 9, 2024

Conversation

sharmasahil
Copy link
Contributor

@sharmasahil sharmasahil commented Nov 11, 2024

Jira

https://digital-vic.atlassian.net/browse/SD-361

Problem/Motivation

Currently, the admin_audit_trail module retains all records since its introduction.

Fix

Created a new drush cmd to clean logs based on time setting and free space.
drush tide_core:auditlog-cleanup

Related PRs

Screenshots

TODO

Copy link
Contributor

@vincent-gao vincent-gao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @sharmasahil
the PR looks good, just some small changes may need to be made.

src/Command/AuditLogCleanupCommand.php Outdated Show resolved Hide resolved
src/Command/AuditLogCleanupCommand.php Outdated Show resolved Hide resolved
src/Command/AuditLogCleanupCommand.php Show resolved Hide resolved
Copy link
Contributor

@vincent-gao vincent-gao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @sharmasahil

@vincent-gao
Copy link
Contributor

@sharmasahil please make sure the build and tests pass.

@sharmasahil sharmasahil merged commit 7c31c61 into develop Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants