[SD-360] Refactor ::getHierarchy #543
Conversation
vincent-gao
requested review from
sharmasahil,
anthony-malkoun,
MdNadimHossain and
yeniatencio
vincent-gao
force-pushed
the
SD-360-refactor-getHierarchy-for-tide_publication
branch
from
93bac1e to
0f81655
Compare
| @@ -181,53 +182,110 @@ public function getHierarchy(EntityInterface $entity, Request $request) { | |||
| * The hierarchy. | |||
| */ | |||
| protected function buildHierarchy(ContentEntityInterface $entity, NestedSetStorage $storage, CacheableMetadata $cache, $weight, array &$flatten_hierarchy, $site = NULL) { | |||
| $resource_type = $this->resourceTypeRepository->get($entity->getEntityTypeId(), $entity->bundle()); | |||
| // Try cache first. | |||
| $cid = "tide_publication:hierarchy:{$entity->uuid()}:{$weight}:" . ($site ? $site->id() : 'null'); | |||
There was a problem hiding this comment.
Why do these get surrounded by {}?
There was a problem hiding this comment.
Hi @anthony-malkoun , it just clearly defines variable boundary in this string.
| $hierarchy = [ | ||
| // Cache the results. | ||
| $cache_data = [ | ||
| 'hierarchy' => $hierarchy, |
There was a problem hiding this comment.
Any reason to save both here? You only use flatten?
There was a problem hiding this comment.
This refactor confused me a bit at first! I wanted to build a hierarchical tree structure while also maintaining a flattened array via the reference parameter 😇 . Anyway, I’ve removed the unnecessary calculation results.
Thanks for catching this issue!
| $cid = "tide_publication:hierarchy:{$entity->uuid()}:{$weight}:" . ($site ? $site->id() : 'null'); | ||
| if ($cached = $this->cacheData->get($cid)) { | ||
| $cache->addCacheTags($cached->tags); | ||
| $flatten_hierarchy = array_merge($flatten_hierarchy, $cached->data['flatten']); |
There was a problem hiding this comment.
I don't get this? Isn't flatten_hierarchy derived from the node?
|
hey @anthony-malkoun |
vincent-gao
deleted the
SD-360-refactor-getHierarchy-for-tide_publication
branch
Jira
https://digital-vic.atlassian.net/browse/SD-360
Problem/Motivation
cache
::buildHierarchyresults. since::buildHierarchyconsumes a significant amount of resources, it's surprising that the results are not being cached~