upgrade to be Version 1.1.1 #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanna extend your plugin but on Github it's still the old version. So, I want to help upgrade your repository to be the latest version :)
I've tested on my site and it seems to work correctly. You can test again before accept my pull request. Anyway, I've tried to run test but it's failed for both the code from http://wordpress.org/plugins/json-api/ and the code after merged. I'm not sure what I did wrong. Please suggest.
Any suggestion, please let me know.
Natty
----- run test result ----
www-data@preproductionmain:~/prontopreview/wp-content/plugins/json-api/tests$ pear run-tests
Running 25 tests
FAIL [ 1/25] core.get_author_index[core.get_author_index-01.phpt]
FAIL [ 2/25] core.get_author_posts by slug[core.get_author_posts-01.phpt]
FAIL [ 3/25] core.get_author_posts by author_slug[core.get_author_posts-02.phpt]
FAIL [ 4/25] core.get_author_posts by id[core.get_author_posts-03.phpt]
FAIL [ 5/25] core.get_category_index[core.get_category_index-01.phpt]
FAIL [ 6/25] core.get_category_posts default[core.get_category_posts-01.phpt]
FAIL [ 7/25] core.get_search_posts default[core.get_date_index-01.phpt]
FAIL [ 8/25] core.get_date_posts by day[core.get_date_posts-01.phpt]
FAIL [ 9/25] core.get_date_posts by month[core.get_date_posts-02.phpt]
FAIL [10/25] core.get_date_posts by year[core.get_date_posts-03.phpt]
FAIL [11/25] core.get_page default[core.get_page-01.phpt]
FAIL [12/25] core.get_page children argument[core.get_page-02.phpt]
FAIL [13/25] core.get_post default[core.get_post-01.phpt]
FAIL [14/25] core.get_posts default[core.get_posts-01.phpt]
FAIL [15/25] core.get_posts by meta key[core.get_posts-02.phpt]
FAIL [16/25] core.get_posts by meta value[core.get_posts-03.phpt]
FAIL [17/25] core.get_recent_posts default[core.get_recent_posts-01.phpt]
FAIL [18/25] core.get_recent_posts count argument[core.get_recent_posts-02.phpt]
FAIL [19/25] core.get_recent_posts page argument[core.get_recent_posts-03.phpt]
FAIL [20/25] core.get_search_posts default[core.get_search_posts-01.phpt]
FAIL [21/25] core.get_tag_index[core.get_tag_index-01.phpt]
FAIL [22/25] core.get_tag_posts default[core.get_tag_posts-01.phpt]
FAIL [23/25] core.info default[core.info-01.phpt]
FAIL [24/25] core.info controller detail[core.info-02.phpt]
FAIL [25/25] core.get_author_index with user-friendly URLs[query-01.phpt]
TOTAL TIME: 00:03
0 PASSED TESTS
0 SKIPPED TESTS
25 FAILED TESTS:
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_author_index-01.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_author_posts-01.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_author_posts-02.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_author_posts-03.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_category_index-01.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_category_posts-01.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_date_index-01.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_date_posts-01.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_date_posts-02.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_date_posts-03.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_page-01.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_page-02.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_post-01.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_posts-01.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_posts-02.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_posts-03.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_recent_posts-01.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_recent_posts-02.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_recent_posts-03.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_search_posts-01.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_tag_index-01.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.get_tag_posts-01.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.info-01.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/core.info-02.phpt
/var/www/prontopreview/wp-content/plugins/json-api/tests/query-01.phpt