This repository has been archived by the owner on Oct 1, 2020. It is now read-only.
feat: added workflows patch to work with redmine 3.4 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #https://www.redmine.org/issues/24281
PROBLEM
In Redmine version 3.4 they added a function in the workflows controller to not show irrelevant permissions, but the redmine_workflow_enhancements plugin did not expect the workflow controller to search for the possible situations for a call type when displaying a workflow. With this, Redmine stopped displaying the situations defined in the configuration of the type of call (which are made by the plugin), displaying only the situations that are in the workflow (Redmine's default behavior)
The change can be found at the following link: https://www.redmine.org/issues/24281
SOLUTION
The solution was to patch the workflows controller by concatenating the situations returned by the workflows_enhancements plugin (which are defined in the call type configuration and have no linked workflow). This patch is only called if the version of Redmine is greater than 3.4 (which was when that function that broke the plugin was added).