Skip to content

Commit

Permalink
Change default settings
Browse files Browse the repository at this point in the history
  • Loading branch information
drachels committed Nov 1, 2023
1 parent e443ef9 commit fa0ae8a
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
6 changes: 3 additions & 3 deletions mod_form.php
Original file line number Diff line number Diff line change
Expand Up @@ -368,16 +368,16 @@ public function data_preprocessing(&$defaultvalues) {

// Set up the completion checkboxes which aren't part of standard data.
// We also make the default value (if you turn on the checkbox) for those
// numbers to be 1, this will not apply unless checkbox is ticked.
// numbers to be 0, this will not apply unless checkbox is ticked.
$defaultvalues['completionpostenabled'] =
!empty($defaultvalues['completionpost']) ? 1 : 0;
if (empty($defaultvalues['completionpost'])) {
$defaultvalues['completionpost'] = 1;
$defaultvalues['completionpost'] = 0;
}
$defaultvalues['completionvoteenabled'] =
!empty($defaultvalues['completionvote']) ? 1 : 0;
if (empty($defaultvalues['completionvote'])) {
$defaultvalues['completionvote'] = 1;
$defaultvalues['completionvote'] = 0;
}
}

Expand Down
6 changes: 6 additions & 0 deletions upgrade.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ This files describes changes in the Hot Question code.
20231027 HotQuestion_1105 - When, Questions for max grading, is not one or more,
you get a non-fatal divide by zero error. Changed code in line 843 of lib.php file
to frevent $factor from being zero.
20231101 HotQuestion_1110 - Can not select just "Student must add question" as the
criteria for Completion Tracking #87. Changed default settings from 1 to 0, for,
$defaultvalues['completionpost'] = 0; and for $defaultvalues['completionvote'] = 0;
in the mod_form.php file.



=== 4.1.8.02+ === 2023101702 released 2023102500
20231025 HotQuestion_1104v - Error when deleting data for user Issue #86 at github.
Expand Down
4 changes: 2 additions & 2 deletions version.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@

defined('MOODLE_INTERNAL') || die();

$plugin->version = 2023101702; // The current module version (Date: YYYYMMDDXX).
$plugin->version = 2023101703; // The current module version (Date: YYYYMMDDXX).
$plugin->requires = 2021051700; // Requires Moodle 3.11 version.
$plugin->cron = 0; // Period for cron to check this module (secs).
$plugin->component = 'mod_hotquestion';
$plugin->maturity = MATURITY_STABLE;
$plugin->release = "4.1.8+ (Build: 2023101702)"; // User-friendly version number.
$plugin->release = "4.1.8+ (Build: 2023101703)"; // User-friendly version number.
$plugin->supported = [311, 403];

0 comments on commit fa0ae8a

Please sign in to comment.