Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac: Fix network detection #303

Merged
merged 2 commits into from
Oct 18, 2024
Merged

mac: Fix network detection #303

merged 2 commits into from
Oct 18, 2024

Conversation

fvincenzo
Copy link
Contributor

There air wifi networks that are not compatible with AirPort. In such a case the network.sh script does not detect correctly the SSID.

The message reported is:
"You are not associated with an AirPort network."

Fix the script detecting correctly the SSID of networks that do not support AirPort.

There air wifi networks that are not compatible with AirPort. In such a
case the network.sh script does not detect correctly the SSID.

The message reported is:
  "You are not associated with an AirPort network."

Fix the script detecting correctly the SSID of networks that do not
support AirPort.
@ethancedwards8
Copy link
Member

ethancedwards8 commented Oct 15, 2024

We actually have an existing PR #291 . Thank you, though.

@fvincenzo
Copy link
Contributor Author

fvincenzo commented Oct 16, 2024

@ethancedwards8 Not a problem, happy to help. According to me PR #291 has a couple of problems in it's last iteration:

  • Invokes ipconfig twice.
  • If the network has airport support networksetup should be the preferred way to detect the SSID.
    Where should I put these comments?

@ethancedwards8
Copy link
Member

@ethancedwards8 Not a problem, happy to help. According to me PR #291 has a couple of problems in it's last iteration:

* Invokes ipconfig twice.

That's a good point.

* If the network has airport support `networksetup` should be the preferred way to detect the SSID.
  Where should I put these comments?

I'm not sure I understand. Why is that preferable?

@fvincenzo
Copy link
Contributor Author

fvincenzo commented Oct 16, 2024

I'm not sure I understand. Why is that preferable?

So that we have a fallback mechanism in place, if networksetup fails we fallback on ipconfig.

@ethancedwards8 ethancedwards8 merged commit 3f892b2 into dracula:master Oct 18, 2024
1 check passed
@ethancedwards8
Copy link
Member

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants