-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GPU Use/mem/power for AMD & Intel GPUs #310
base: master
Are you sure you want to change the base?
Conversation
first of all im very happy to see these changes, thank you very much! |
That's a great point. There should still be an unknown fallback. I'll see if I can beg/borrow/steal an Intel laptop at work to test it on. Though that raises an interesting question. As is, it detects multiple GPUs that share the data source structure, but having it handle something like an integrated Intel with discrete Nvidia or AMD, as many laptops have, would be handy. I have neither... but again, work may have something I can pilfer for a day. |
I can only find devices with Intel and Matrox iGPUs, no discreet or Arc ones. What I have show up as |
awesome! the only thing left to talk about is the normalize_percent_len that you removed |
The values returned by vram and power aren't single entry percentages (##.#GB/##GB, and ###W/###W) so it over pads slightly. Each additional gpu doubles that padding leading to almost having as much whitespace between VRAM and the values as the values themselves take up. |
that is fair, but taking away the padding from the other options isnt necessarily the way to go either. do you think you can figure out a solution where amd is unpadded but nvidia and apple keep their padding? |
Changes unknown outputs by
scripts/gpu_*
to be the correct output for 1 or more AMD/Intel GPUsGPU 0%|0% VRAM 34MB/4.0GB|1.2GB/8.0GB GPUP 1/43W|16/156W