Skip to content

Commit

Permalink
fix(pytest): fix failing test test_replication_timeout_on_full_sync (#…
Browse files Browse the repository at this point in the history
…4370)

fix: increase timeout
fix: remove skip

Signed-off-by: adi_holden <[email protected]>
  • Loading branch information
adiholden authored Dec 25, 2024
1 parent 966a1a4 commit 14fda35
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions tests/dragonfly/replication_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -2274,7 +2274,6 @@ async def test_announce_ip_port(df_factory):
assert port == "1337"


@pytest.mark.skip("Flaky test")
async def test_replication_timeout_on_full_sync(df_factory: DflyInstanceFactory, df_seeder_factory):
# setting replication_timeout to a very small value to force the replica to timeout
master = df_factory.create(replication_timeout=100, vmodule="replica=2,dflycmd=2")
Expand Down Expand Up @@ -2309,7 +2308,7 @@ async def test_replication_timeout_on_full_sync(df_factory: DflyInstanceFactory,
seeder.stop()
await seeder_task

await check_all_replicas_finished([c_replica], c_master)
await check_all_replicas_finished([c_replica], c_master, timeout=30)
await assert_replica_reconnections(replica, 0)


Expand Down

0 comments on commit 14fda35

Please sign in to comment.