chore: parser cleanups #4076
Open
chore: parser cleanups #4076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
previously approved these changes
Nov 6, 2024
src/facade/redis_parser.cc
Outdated
| InitStart(str[0], res); | ||
| } | ||
| DCHECK(state_ != CMD_COMPLETE_S); |
There was a problem hiding this comment.
I had to check this. InitStart does update state_ if it's equal CMD_COMPLETE_S so it's fine.
src/facade/redis_parser.cc
Outdated
| if (pos[-1] != '\r') { | ||
| return BAD_INT; | ||
|
|
||
| consumed = pos - s + 1; |
There was a problem hiding this comment.
I am blindly trusting you here. I haven;t checked the index calculations but the tests are failing and it's a sign that there is a mistake somewhere around here 😄
|
Tests are failing :) |
romange
force-pushed
the
Parser
branch
3 times, most recently
from
759f1e7 to
93682c7
Compare
kostasrim
previously approved these changes
Nov 7, 2024
romange
force-pushed
the
Parser
branch
9 times, most recently
from
dbf8419 to
6ce0516
Compare
romange
force-pushed
the
Parser
branch
4 times, most recently
from
e84c303 to
b788c86
Compare
romange
force-pushed
the
Parser
branch
3 times, most recently
from
63a3bf1 to
f7fa90c
Compare
|
@romange still not green |
|
And I still have not requested to review :) |
Uhhh I saw the notification and saw you asked 😄 nvm |
romange
force-pushed
the
Parser
branch
6 times, most recently
from
ae13a73 to
002d26d
Compare
1. Separate argument type parsing from argument parsing itself. 2. Handle strings of length 1. This is done in preparation of improving the parser contract - so that when it returns INPUT_PENDING, it consumes the entire input. Signed-off-by: Roman Gershman <[email protected]>
This is needed in order to eliminate cases where we return INPUT_PENDING but do not consume the whole string by rejecting just several bytes. This should simplify buffer management for the caller, so that if they pass a string that did not result in complete parsed request, at least the whole string is consumed and can be discarded. Signed-off-by: Roman Gershman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, eliminate cases where we return INPUT_PENDING but do not consume the whole string. This should simplify buffer management for the caller, so that if they pass a string that did not result in complete parsed request, at least the whole string is consumed and can be discarded.
This PR handles only the ParseLen function that now stashes all the partial data if not enough data is provided.