Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test_network_disconnect_during_migration #4345

Merged
merged 1 commit into from
Dec 22, 2024
Merged

fix: test_network_disconnect_during_migration #4345

merged 1 commit into from
Dec 22, 2024

Conversation

BorysTheDev
Copy link
Contributor

fixes: #4344
small changes that close resources correctly and help debug the test if it fails again

chakaz
chakaz approved these changes Dec 22, 2024
View reviewed changes
Copy link
Collaborator

@chakaz chakaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but does it really fix the issue (like the description suggests), or does it only clean up and add logs?

@BorysTheDev
Copy link
Contributor Author

@chakaz I can not reproduce the issue even on CI, so I hope if it still exists these changes help me

@BorysTheDev BorysTheDev merged commit 76000b9 into main Dec 22, 2024
9 checks passed
@BorysTheDev BorysTheDev deleted the fix_test_network_disconnect_during_migration branch December 22, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chakaz chakaz chakaz approved these changes

@adiholden adiholden Awaiting requested review from adiholden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_network_disconnect_during_migration is flaky
2 participants
@BorysTheDev @chakaz