feat: remove TriggerDownloadTaskResponse in TriggerDownloadTask (#238)

Signed-off-by: Gaius <[email protected]>
dragonflyoss · Dec 19, 2023 · a71c5bd · a71c5bd
1 parent 82e3f21
commit a71c5bd
Show file tree

Hide file tree

Showing 9 changed files with 172 additions and 349 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "dragonfly-api"
-version = "2.0.69"
+version = "2.0.70"
 authors = ["Gaius <[email protected]>"]
 edition = "2021"
 license = "Apache-2.0"

diff --git a/pkg/apis/dfdaemon/v2/dfdaemon.pb.go b/pkg/apis/dfdaemon/v2/dfdaemon.pb.go
diff --git a/pkg/apis/dfdaemon/v2/dfdaemon.pb.validate.go b/pkg/apis/dfdaemon/v2/dfdaemon.pb.validate.go
diff --git a/pkg/apis/dfdaemon/v2/dfdaemon.proto b/pkg/apis/dfdaemon/v2/dfdaemon.proto
@@ -30,10 +30,6 @@ message TriggerDownloadTaskRequest {
   common.v2.Download download = 1 [(validate.rules).message.required = true];
 }
 
-// TriggerDownloadTaskResponse represents response of TriggerDownloadTask.
-message TriggerDownloadTaskResponse {
-}
-
 // SyncPiecesRequest represents request of SyncPieces.
 message SyncPiecesRequest {
   // Task id.
@@ -65,7 +61,7 @@ message DownloadPieceResponse {
 // DfdaemonUpload represents dfdaemon upload service.
 service DfdaemonUpload {
   // TriggerDownloadTask triggers download task.
-  rpc TriggerDownloadTask(TriggerDownloadTaskRequest) returns(TriggerDownloadTaskResponse);
+  rpc TriggerDownloadTask(TriggerDownloadTaskRequest) returns(google.protobuf.Empty);
 
   // SyncPieces syncs piece metadatas from remote peer.
   rpc SyncPieces(SyncPiecesRequest) returns(stream SyncPiecesResponse);

diff --git a/pkg/apis/dfdaemon/v2/dfdaemon_grpc.pb.go b/pkg/apis/dfdaemon/v2/dfdaemon_grpc.pb.go
diff --git a/pkg/apis/dfdaemon/v2/mocks/dfdaemon_mock.go b/pkg/apis/dfdaemon/v2/mocks/dfdaemon_mock.go
diff --git a/proto/dfdaemon.proto b/proto/dfdaemon.proto
@@ -27,10 +27,6 @@ message TriggerDownloadTaskRequest {
   common.v2.Download download = 1;
 }
 
-// TriggerDownloadTaskResponse represents response of TriggerDownloadTask.
-message TriggerDownloadTaskResponse {
-}
-
 // SyncPiecesRequest represents request of SyncPieces.
 message SyncPiecesRequest {
   // Task id.
@@ -62,7 +58,7 @@ message DownloadPieceResponse {
 // DfdaemonUpload represents upload service of dfdaemon.
 service DfdaemonUpload{
   // TriggerDownloadTask triggers download task.
-  rpc TriggerDownloadTask(TriggerDownloadTaskRequest) returns(TriggerDownloadTaskResponse);
+  rpc TriggerDownloadTask(TriggerDownloadTaskRequest) returns(google.protobuf.Empty);
 
   // SyncPieces syncs piece metadatas from remote peer.
   rpc SyncPieces(SyncPiecesRequest) returns(stream SyncPiecesResponse);

diff --git a/src/descriptor.bin b/src/descriptor.bin
diff --git a/src/dfdaemon.v2.rs b/src/dfdaemon.v2.rs
@@ -7,11 +7,6 @@ pub struct TriggerDownloadTaskRequest {
     #[prost(message, optional, tag = "1")]
     pub download: ::core::option::Option<super::super::common::v2::Download>,
 }
-/// TriggerDownloadTaskResponse represents response of TriggerDownloadTask.
-#[derive(serde::Serialize, serde::Deserialize)]
-#[allow(clippy::derive_partial_eq_without_eq)]
-#[derive(Clone, PartialEq, ::prost::Message)]
-pub struct TriggerDownloadTaskResponse {}
 /// SyncPiecesRequest represents request of SyncPieces.
 #[derive(serde::Serialize, serde::Deserialize)]
 #[allow(clippy::derive_partial_eq_without_eq)]
@@ -201,10 +196,7 @@ pub mod dfdaemon_upload_client {
         pub async fn trigger_download_task(
             &mut self,
             request: impl tonic::IntoRequest<super::TriggerDownloadTaskRequest>,
-        ) -> std::result::Result<
-            tonic::Response<super::TriggerDownloadTaskResponse>,
-            tonic::Status,
-        > {
+        ) -> std::result::Result<tonic::Response<()>, tonic::Status> {
             self.inner
                 .ready()
                 .await
@@ -476,10 +468,7 @@ pub mod dfdaemon_upload_server {
         async fn trigger_download_task(
             &self,
             request: tonic::Request<super::TriggerDownloadTaskRequest>,
-        ) -> std::result::Result<
-            tonic::Response<super::TriggerDownloadTaskResponse>,
-            tonic::Status,
-        >;
+        ) -> std::result::Result<tonic::Response<()>, tonic::Status>;
         /// Server streaming response type for the SyncPieces method.
         type SyncPiecesStream: futures_core::Stream<
                 Item = std::result::Result<super::SyncPiecesResponse, tonic::Status>,
@@ -587,7 +576,7 @@ pub mod dfdaemon_upload_server {
                         T: DfdaemonUpload,
                     > tonic::server::UnaryService<super::TriggerDownloadTaskRequest>
                     for TriggerDownloadTaskSvc<T> {
-                        type Response = super::TriggerDownloadTaskResponse;
+                        type Response = ();
                         type Future = BoxFuture<
                             tonic::Response<Self::Response>,
                             tonic::Status,