feat: set output_path to optional and add need_piece_content for downloading persistent cache #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaius-qi
force-pushed
the
feature/need
branch
3 times, most recently
from
106961e to
38c8f3a
Compare
…loading persistent cache Signed-off-by: Gaius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes updates to the
dragonfly-apipackage version and several changes to theDownloadPersistentCacheTaskRequeststruct in thedfdaemon.pb.gofile to enhance functionality and improve code robustness.Version Update:
Cargo.toml: Updated the package version from2.1.1to2.1.2.Enhancements to
DownloadPersistentCacheTaskRequest:pkg/apis/dfdaemon/v2/dfdaemon.pb.go: Changed theOutputPathfield to be a pointer, ensuring it can be nil.pkg/apis/dfdaemon/v2/dfdaemon.pb.go: Added a new boolean fieldNeedPieceContentto indicate whether the response should include piece content.pkg/apis/dfdaemon/v2/dfdaemon.pb.go: Updated theGetOutputPathmethod to handle the new pointer type forOutputPath.pkg/apis/dfdaemon/v2/dfdaemon.pb.go: Added a new methodGetNeedPieceContentto retrieve the value of the newNeedPieceContentfield.pkg/apis/dfdaemon/v2/dfdaemon.pb.go: Updated the raw descriptor to reflect the changes in theDownloadPersistentCacheTaskRequeststruct.Related Issue
Motivation and Context