feat: add ReadPersistentCacheTask and WritePersistentCacheTask message #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxxhero
previously approved these changes
Jan 15, 2025
CormickKneey
previously approved these changes
Jan 15, 2025
gaius-qi
force-pushed
the
feature/read-write
branch
from
6f67539 to
d2158f3
Compare
Signed-off-by: Gaius <[email protected]>
gaius-qi
force-pushed
the
feature/read-write
branch
from
d2158f3 to
2b24cca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces new functionality for handling persistent cache tasks in the
dfdaemonservice. The changes include updates to the protobuf definitions, gRPC service interfaces, and generated Rust code to support writing and reading persistent cache tasks.Protobuf and gRPC Updates:
WritePersistentCacheTaskRequest,WritePersistentCacheTaskStartedRequest,WritePersistentCacheTaskFinishedRequest,WriteChunkRequest,WritePersistentCacheTaskResponse,ReadPersistentCacheTaskRequest,ReadPersistentCacheTaskResponse,ReadPersistentCacheTaskFinishedResponse, andReadChunkResponseinpkg/apis/dfdaemon/v2/dfdaemon.protoandproto/dfdaemon.proto. [1] [2]WritePersistentCacheTaskandReadPersistentCacheTaskto theDfdaemonDownloadservice inpkg/apis/dfdaemon/v2/dfdaemon.protoandproto/dfdaemon.proto. [1] [2]gRPC Client and Server Implementation:
WritePersistentCacheTaskand server-side streaming forReadPersistentCacheTaskinpkg/apis/dfdaemon/v2/dfdaemon_grpc.pb.go. [1] [2] [3] [4] [5] [6]Rust Code Updates:
src/dfdaemon.v2.rs.Version Update:
dragonfly-apipackage from2.1.4to2.1.5inCargo.toml.Related Issue
Motivation and Context