Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests for dragonfly-backend::http #770

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Lzzzzzt
Copy link
Contributor

@Lzzzzzt Lzzzzzt commented Oct 12, 2024

Add https related unit tests for dragonfly-backend::http.

Description

This PR is done by finishing the following tasks:

  • Add test for get/head with self-signed cert.
  • Add test for get/head with wrong cert.
  • Add test for get/head with no verifier.

Related Issue

#399

@Lzzzzzt Lzzzzzt requested a review from a team as a code owner October 12, 2024 02:44
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.32%. Comparing base (3973842) to head (6495732).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
+ Coverage   27.48%   29.32%   +1.84%     
==========================================
  Files          55       55              
  Lines        7724     7883     +159     
==========================================
+ Hits         2123     2312     +189     
+ Misses       5601     5571      -30     
Files with missing lines Coverage Δ
dragonfly-client-backend/src/http.rs 97.09% <100.00%> (+5.70%) ⬆️
dragonfly-client-core/src/error/mod.rs 66.66% <ø> (ø)

... and 1 file with indirect coverage changes

@Lzzzzzt Lzzzzzt force-pushed the main branch 3 times, most recently from 0f78708 to 8c0cc9f Compare October 12, 2024 05:34
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 6e26222 into dragonflyoss:main Oct 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants