osd: Remove bogus assert(active == acting.size())

We saw this assert because active is not correctly computed. Remove assert and incorrectly computed active count. We already use acting.size() to determine whether to set PG_STATE_DEGRADED. Fixes: ceph#6896 Signed-off-by: David Zafman <[email protected]>
dragonylffly · Nov 25, 2013 · 66f51f8 · 66f51f8
1 parent 5ccc2ec
commit 66f51f8
Showing 1 changed file with 0 additions and 8 deletions.
diff --git a/src/osd/PG.cc b/src/osd/PG.cc
@@ -1204,9 +1204,6 @@ void PG::activate(ObjectStore::Transaction& t,
   if (is_primary()) {
     // start up replicas
 
-    // count replicas that are not backfilling
-    unsigned active = 1;
-
     assert(actingbackfill.size() > 0);
     for (unsigned i=1; i<actingbackfill.size(); i++) {
       int peer = actingbackfill[i];
@@ -1269,9 +1266,6 @@ void PG::activate(ObjectStore::Transaction& t,
       if (needs_past_intervals)
 	m->past_intervals = past_intervals;
 
-      if (pi.last_backfill == hobject_t::get_max())
-	active++;
-
       // update local version of peer's missing list!
       if (m && pi.last_backfill != hobject_t()) {
         for (list<pg_log_entry_t>::iterator p = m->log.log.begin();
@@ -1299,8 +1293,6 @@ void PG::activate(ObjectStore::Transaction& t,
       }
     }
 
-    assert(active == acting.size());
-
     // degraded?
     if (get_osdmap()->get_pg_size(info.pgid) > acting.size())
       state_set(PG_STATE_DEGRADED);