Skip to content

Commit

Permalink
rgw: drop async pool create completion reference
Browse files Browse the repository at this point in the history
Fixes: ceph#6444
Backport: dumpling
If pool creation fails (e.g., due to -EEXIST) then we leak the
completion object. Earlier we couldn't just drop the reference, as
librados have already removed the internal completion object. This fix
drop the completion reference even if got an error, which is now
possible.

Signed-off-by: Yehuda Sadeh <[email protected]>
  • Loading branch information
yehudasa committed Sep 30, 2013
1 parent 4605792 commit 8912462
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/rgw/rgw_rados.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2182,8 +2182,8 @@ int RGWRados::create_pools(vector<string>& names, vector<int>& retcodes)
if (r < 0) {
ldout(cct, 0) << "WARNING: async pool_create returned " << r << dendl;
}
c->release();
}
c->release();
retcodes.push_back(r);
}
return 0;
Expand Down

0 comments on commit 8912462

Please sign in to comment.