Skip to content

Commit

Permalink
config_opts.h: increase xfs,btrfs wbthrottle defaults
Browse files Browse the repository at this point in the history
Also increase fd limit defaults to accomodate the larger number
of fds.

Fixes: ceph#5692
Signed-off-by: Samuel Just <[email protected]>
Reviewed-by: Sage Weil <[email protected]>
Reviewed-by: Mark Nelson <[email protected]>
  • Loading branch information
Samuel Just committed Jul 25, 2013
1 parent 870c474 commit f653aa5
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 14 deletions.
6 changes: 6 additions & 0 deletions PendingReleaseNotes
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,9 @@ v0.67
copy operations. The S3 response will now return extra <Progress>
field under the <CopyResult> container. The Swift response will
now send the progress as a json array.

* ceph-osd now requires a max fd limit of at least
filestore_wbthrottle_(xfs|btrfs)_inodes_hard_limit (5000 by default)
in order to accomodate the new write back throttle system. upstart
now sets the fd limit to 32k. sysvinit will set it to 32k by default
(still overrideable via max_open_files).
24 changes: 12 additions & 12 deletions src/common/config_opts.h
Original file line number Diff line number Diff line change
Expand Up @@ -501,20 +501,20 @@ OPTION(osd_max_attr_size, OPT_U64, 65536)
OPTION(filestore, OPT_BOOL, false)

/// filestore wb throttle limits
OPTION(filestore_wbthrottle_btrfs_bytes_start_flusher, OPT_U64, 10<<20)
OPTION(filestore_wbthrottle_btrfs_bytes_hard_limit, OPT_U64, 100<<20)
OPTION(filestore_wbthrottle_btrfs_ios_start_flusher, OPT_U64, 100)
OPTION(filestore_wbthrottle_btrfs_ios_hard_limit, OPT_U64, 1000)
OPTION(filestore_wbthrottle_btrfs_inodes_start_flusher, OPT_U64, 100)
OPTION(filestore_wbthrottle_xfs_bytes_start_flusher, OPT_U64, 10<<20)
OPTION(filestore_wbthrottle_xfs_bytes_hard_limit, OPT_U64, 100<<20)
OPTION(filestore_wbthrottle_xfs_ios_start_flusher, OPT_U64, 10)
OPTION(filestore_wbthrottle_xfs_ios_hard_limit, OPT_U64, 100)
OPTION(filestore_wbthrottle_xfs_inodes_start_flusher, OPT_U64, 10)
OPTION(filestore_wbthrottle_btrfs_bytes_start_flusher, OPT_U64, 41943040)
OPTION(filestore_wbthrottle_btrfs_bytes_hard_limit, OPT_U64, 419430400)
OPTION(filestore_wbthrottle_btrfs_ios_start_flusher, OPT_U64, 500)
OPTION(filestore_wbthrottle_btrfs_ios_hard_limit, OPT_U64, 5000)
OPTION(filestore_wbthrottle_btrfs_inodes_start_flusher, OPT_U64, 500)
OPTION(filestore_wbthrottle_xfs_bytes_start_flusher, OPT_U64, 41943040)
OPTION(filestore_wbthrottle_xfs_bytes_hard_limit, OPT_U64, 419430400)
OPTION(filestore_wbthrottle_xfs_ios_start_flusher, OPT_U64, 500)
OPTION(filestore_wbthrottle_xfs_ios_hard_limit, OPT_U64, 5000)
OPTION(filestore_wbthrottle_xfs_inodes_start_flusher, OPT_U64, 500)

/// These must be less than the fd limit
OPTION(filestore_wbthrottle_btrfs_inodes_hard_limit, OPT_U64, 256)
OPTION(filestore_wbthrottle_xfs_inodes_hard_limit, OPT_U64, 100)
OPTION(filestore_wbthrottle_btrfs_inodes_hard_limit, OPT_U64, 5000)
OPTION(filestore_wbthrottle_xfs_inodes_hard_limit, OPT_U64, 5000)

// Tests index failure paths
OPTION(filestore_index_retry_probability, OPT_DOUBLE, 0)
Expand Down
2 changes: 1 addition & 1 deletion src/init-ceph.in
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ for name in $what; do
case "$command" in
start)
# Increase max_open_files, if the configuration calls for it.
get_conf max_open_files "8192" "max open files"
get_conf max_open_files "32768" "max open files"

# build final command
wrap=""
Expand Down
2 changes: 1 addition & 1 deletion src/upstart/ceph-osd.conf
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ stop on runlevel [!2345] or stopping ceph-osd-all
respawn
respawn limit 5 30

limit nofile 16384 16384
limit nofile 32768 32768

pre-start script
set -e
Expand Down

0 comments on commit f653aa5

Please sign in to comment.