Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial updates to add tests that cause the failure #52

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

draperd
Copy link
Owner

@draperd draperd commented Feb 19, 2019

This is a work in progress PR to start addressing #47 .... I've added a test to reproduce the problem but haven't been able to add a solution yet that doesn't break other tests. I'll continue to investigate and try to get a good solution that doesn't require breaking changes.

@draperd
Copy link
Owner Author

draperd commented Mar 2, 2019

I've had to bite the bullet here and look to add a defaultValue to the Form component (which arguably I should have done originally). This will mean that using the Form component with a value rather than a defaultValue will mean that it will have to be fully controlled (e.g. changes captured and passed back as the new value) but this is probably a better pattern anyway.

Unfortunately I still have one unit test failing following my latest changes. Apologies this is taking so long to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant