Enable LTO in Rust release profile

[ruokun-niu]

Description

Enabling Link Time Optimization (LTO) will reduce the binary size. By setting lto to be true in the release profile, LTO will only be enabled in our release build, as we use the command cargo install in our dockerfiles. When we do a local cargo build, LTO will not be enabled. To enable LTO in cargo build, run with the --release flag

Type of change

• This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Drasi (issue link optional).

Fixes: #97

[danielgerlag]

What about the development workflow where you need to build the docker image and load it to kind for local testing?
I think we need a flag on the make command?

[ruokun-niu]

What about the development workflow where you need to build the docker image and load it to kind for local testing? I think we need a flag on the make command?

Our makefile uses docker to build the image, which should use cargo install as well. When we run cargo install, the release profile will be used

[danielgerlag]

What about the development workflow where you need to build the docker image and load it to kind for local testing? I think we need a flag on the make command?

Our makefile uses docker to build the image, which should use cargo install as well. When we run cargo install, the release profile will be used

Can we have a flag or ENV variable to control this, so that we can build the docker images without LTO by default?

[ruokun-niu]

What about the development workflow where you need to build the docker image and load it to kind for local testing? I think we need a flag on the make command?

Our makefile uses docker to build the image, which should use cargo install as well. When we run cargo install, the release profile will be used

Can we have a flag or ENV variable to control this, so that we can build the docker images without LTO by default?

I'll look into it

[ruokun-niu]

What about the development workflow where you need to build the docker image and load it to kind for local testing? I think we need a flag on the make command?

Our makefile uses docker to build the image, which should use cargo install as well. When we run cargo install, the release profile will be used

Can we have a flag or ENV variable to control this, so that we can build the docker images without LTO by default?

I have updated the makefiles and added the following section to the contributing-code-building readme:

By default, all our Rust-based images use the release profile in builds, which sets Link-time Optimization (LTO) to true. For more information on Rust profiles and the use of LTO in Rust projects, see Profiles. If you wish to use the default LTO setting, you can use the CARGO_DEBUG parameter as follows:

make docker-build CARGO_DEBUG=1

[danielgerlag]

What about the development workflow where you need to build the docker image and load it to kind for local testing? I think we need a flag on the make command?

Our makefile uses docker to build the image, which should use cargo install as well. When we run cargo install, the release profile will be used

Can we have a flag or ENV variable to control this, so that we can build the docker images without LTO by default?

I have updated the makefiles and added the following section to the contributing-code-building readme:

By default, all our Rust-based images use the release profile in builds, which sets Link-time Optimization (LTO) to true. For more information on Rust profiles and the use of LTO in Rust projects, see Profiles. If you wish to use the default LTO setting, you can use the CARGO_DEBUG parameter as follows:

make docker-build CARGO_DEBUG=1

Great, I think the default should be without LTO, so when you want to cut a release build it would be something like

make docker-build RELEASE=1

[ruokun-niu]

What about the development workflow where you need to build the docker image and load it to kind for local testing? I think we need a flag on the make command?

Our makefile uses docker to build the image, which should use cargo install as well. When we run cargo install, the release profile will be used

Can we have a flag or ENV variable to control this, so that we can build the docker images without LTO by default?

I have updated the makefiles and added the following section to the contributing-code-building readme:
By default, all our Rust-based images use the release profile in builds, which sets Link-time Optimization (LTO) to true. For more information on Rust profiles and the use of LTO in Rust projects, see Profiles. If you wish to use the default LTO setting, you can use the CARGO_DEBUG parameter as follows:

make docker-build CARGO_DEBUG=1

Great, I think the default should be without LTO, so when you want to cut a release build it would be something like

make docker-build RELEASE=1

Good point. Will configure this after I fix the build-test workflow

[danielgerlag]

Let's make the default 0

[danielgerlag]

Let's make the default 0

[danielgerlag]

could we just include this arg in the $(DOCKERX_OPTS) string?

[danielgerlag]

Then you would not need to modify the make files at all, you could just pass it as a parameter

[danielgerlag]

could we just include this arg in the $(DOCKERX_OPTS) string?
Then you would not need to modify the make files at all, you could just pass it as a parameter

[danielgerlag]

could we just include this arg in the $(DOCKERX_OPTS) string?
Then you would not need to modify the make files at all, you could just pass it as a parameter

[danielgerlag]

Let's make the default 0

[danielgerlag]

Is this still accurate?