Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed field circle icons not moving in Safari #35

Merged
merged 4 commits into from
Apr 14, 2024

Conversation

ClaPalo
Copy link
Contributor

@ClaPalo ClaPalo commented Apr 12, 2024

Fix to #32.
For some reason, the problem seems to be related to the opacity of the buttons. I fixed it by setting the opacity back to 1, which doesn't seem to ruin the UX.

Copy link

vercel bot commented Apr 12, 2024

@ClaPalo is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

@haecheonlee
Copy link
Contributor

The issue seems to be related with the style of transform set to g in Canvas.jsx. And the transform state is set by diagram. Personally, removing those style should not be relevant to the position of an element. We may need further investigation to solve it properly.

@ClaPalo
Copy link
Contributor Author

ClaPalo commented Apr 12, 2024

It seems that by using RGBA for the colors, it's possible to set to opacity without creating the issue.

@haecheonlee
Copy link
Contributor

haecheonlee commented Apr 13, 2024

This seems to be the solution to fix it. I cannot find any other approach. I created a PR to fix another issue that renders the buttons in the wrong position.

#44

@haecheonlee
Copy link
Contributor

haecheonlee commented Apr 13, 2024

Fix seems to be required for Notes and subject area as well. I will open another issue for this.

Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

vercel bot commented Apr 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drawdb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2024 7:01am

@1ilit 1ilit merged commit 1649d07 into drawdb-io:main Apr 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants