Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): update formula data model #4159

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Nov 26, 2024

What's updated?

  • remove formula data in formulaDataModel. Large memory case decreased from 2100M to 1903M

How to test?

Test any formula-related use cases

For example

  • Normal SUM calculation
  • Cross-sheet formula
  • Array formula
  • Ref range change

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 26, 2024

Playwright test results

failed  2 failed
passed  18 passed

Details

stats  20 tests across 9 suites
duration  6 minutes, 39 seconds
commit  76d18da
info  For more information, see full report

Failed tests

chromium › disposing/disposing.spec.ts › no error when dispose a unit
chromium › memory/memory.spec.ts › memory

@Dushusir Dushusir force-pushed the dushusir/formula-data-model1125 branch from 4d3b3fa to 6f4e86b Compare November 27, 2024 07:20
@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 33.78%. Comparing base (1a9f83d) to head (76d18da).

Files with missing lines Patch % Lines
...es/engine-formula/src/models/formula-data.model.ts 73.23% 19 Missing ⚠️
...rmula/src/controllers/update-formula.controller.ts 0.00% 9 Missing ⚠️
...ui/src/controllers/formula-clipboard.controller.ts 33.33% 2 Missing ⚠️
.../src/controllers/formula-editor-show.controller.ts 0.00% 2 Missing ⚠️
...gine-formula/src/models/utils/formula-data-util.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4159   +/-   ##
=======================================
  Coverage   33.77%   33.78%           
=======================================
  Files        2457     2457           
  Lines      127720   127687   -33     
  Branches    28604    28587   -17     
=======================================
  Hits        43139    43139           
+ Misses      84581    84548   -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir marked this pull request as ready for review November 27, 2024 07:39
@Dushusir Dushusir force-pushed the dushusir/formula-data-model1125 branch from 6f4e86b to 76d18da Compare November 27, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant