Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selection expand with shift #4166

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Nov 27, 2024

close https://github.com/dream-num/univer-pro/issues/3537

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 27, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 27, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 47 seconds
commit  27b812b
info  For more information, see full report

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 33.77%. Comparing base (1a9f83d) to head (27b812b).

Files with missing lines Patch % Lines
...ts-formula-ui/src/controllers/prompt.controller.ts 0.00% 3 Missing ⚠️
...rc/services/selection/selection-shape-extension.ts 0.00% 3 Missing ⚠️
...src/services/selection/selection-render.service.ts 0.00% 2 Missing ⚠️
...sheets-ui/src/controllers/move-range.controller.ts 0.00% 1 Missing ⚠️
...ets-ui/src/services/selection/selection-control.ts 0.00% 1 Missing ⚠️
...ts/src/services/selections/selection-data-model.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4166      +/-   ##
==========================================
- Coverage   33.77%   33.77%   -0.01%     
==========================================
  Files        2457     2457              
  Lines      127720   127721       +1     
  Branches    28604    28605       +1     
==========================================
  Hits        43139    43139              
- Misses      84581    84582       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the fix/selection-expand-with-shift branch 3 times, most recently from 7db9425 to b1918ba Compare November 27, 2024 10:05
@lumixraku lumixraku force-pushed the fix/selection-expand-with-shift branch from b1918ba to 27b812b Compare November 27, 2024 10:06
@lumixraku lumixraku marked this pull request as ready for review November 27, 2024 10:13
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant