Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selection expand with shift #4166

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Nov 27, 2024

close https://github.com/dream-num/univer-pro/issues/3537
close https://github.com/dream-num/univer-pro/issues/3524

close https://github.com/dream-num/univer-pro/issues/3576

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 27, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 27, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 49 seconds
commit  6a534c1
info  For more information, see full report

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 44 lines in your changes missing coverage. Please review.

Project coverage is 33.68%. Comparing base (1de083c) to head (6a534c1).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ts-formula-ui/src/controllers/prompt.controller.ts 0.00% 14 Missing ⚠️
...src/services/selection/selection-render.service.ts 0.00% 8 Missing ⚠️
...ts/src/services/selections/selection-data-model.ts 50.00% 8 Missing ⚠️
...s/render-services/ref-selections.render-service.ts 0.00% 6 Missing ⚠️
...rc/services/selection/selection-shape-extension.ts 0.00% 3 Missing ⚠️
...sheets-ui/src/controllers/move-range.controller.ts 0.00% 1 Missing ⚠️
...heets-ui/src/controllers/utils/selections-tools.ts 0.00% 1 Missing ⚠️
...ervices/selection/base-selection-render.service.ts 0.00% 1 Missing ⚠️
...ets-ui/src/services/selection/selection-control.ts 0.00% 1 Missing ⚠️
.../src/services/selections/ref-selections.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4166      +/-   ##
==========================================
+ Coverage   33.67%   33.68%   +0.01%     
==========================================
  Files        2490     2490              
  Lines      128019   128028       +9     
  Branches    28692    28695       +3     
==========================================
+ Hits        43105    43128      +23     
+ Misses      84914    84900      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the fix/selection-expand-with-shift branch 4 times, most recently from b1918ba to 27b812b Compare November 27, 2024 10:06
@lumixraku lumixraku requested a review from Gggpound November 27, 2024 10:11
@lumixraku lumixraku marked this pull request as ready for review November 27, 2024 10:13
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 27, 2024
@lumixraku lumixraku force-pushed the fix/selection-expand-with-shift branch from 27b812b to c96e249 Compare November 28, 2024 04:16
@lumixraku lumixraku self-assigned this Nov 28, 2024
@oumomomo
Copy link

oumomomo commented Nov 29, 2024

https://github.com/dream-num/univer-pro/issues/3537

问题1、
选中行作为公式选区后使用shift+左右键
选中列作为公式选区后使用shift+上下键

预期表现:无法调整选区
实际表现:可以调整选区,且调整选区后背景色超出
2024_11_29 11_42_49 video.webm

@univer-bot
Copy link

univer-bot bot commented Nov 29, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

https://github.com/dream-num/univer-pro/issues/3537

Question 1.
After selecting the row as a formula selection, use shift + left and right keys
After selecting a column as a formula selection, use shift+up and down keys

Expected performance: Unable to adjust selection
Actual performance: The selection can be adjusted, and the background color exceeds the
2024_11_29 11_42_49 video.webm

@univer-bot
Copy link

univer-bot bot commented Nov 29, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

https://github.com/dream-num/univer-pro/issues/3537
Question 2: When Table 1 refers to the selection of Table 2 across tables, the selection cannot be adjusted using shift+arrow keys.
2024_11_29 11_46_54 video.webm

Expected performance: can be adjusted normally

@oumomomo
Copy link

oumomomo commented Nov 29, 2024

https://github.com/dream-num/univer-pro/issues/3537

问题2、引用行列使用shift+方向键

实际表现
引用行列时使用方向键会展示列标题+行序号
image

excel表现:
引用列时使用左右键调整选区,公式内仅展示列标题不展示单元格序号
2024_11_29 11_54_45 video.webm
image

引用行时使用上下键调整选区,仅展示行序号不展示列标题
image

@univer-bot
Copy link

univer-bot bot commented Nov 29, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

https://github.com/dream-num/univer-pro/issues/3537

Question 2. Use shift+arrow keys to reference rows and columns.

actual performance
When referencing a row or column, using the arrow keys will display the column title + row number.
image

excel performance:
When referencing a column, use the left and right keys to adjust the selection. Only the column title is displayed in the formula and the cell serial number is not displayed.
2024_11_29 11_54_45 video.webm
image

When referencing a row, use the up and down keys to adjust the selection. Only row numbers are displayed and column titles are not displayed.
image

@univer-bot
Copy link

univer-bot bot commented Nov 29, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

https://github.com/dream-num/univer-pro/issues/3524

Note: After referencing the selection in Table 1, the format is =I21:J25,K27:M32. The comma after the second selection is switched to Table 2 and added, otherwise it cannot be reproduced.

  1. Enter = in the cell of Table 1 to reference the two selections in this table.
  2. Switch to Table 2 input, and then reference a selection
  3. Switch back to Table 1 to view the selection lines
    2024_11_29 14_34_14 video.webm

Expected performance: The selection lines in Table 1 are displayed normally.
Actual performance: The selection lines in Table 1 are not displayed.

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 29, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 29, 2024
@univer-bot univer-bot bot removed the qa:rejected label Nov 29, 2024
@lumixraku lumixraku force-pushed the fix/selection-expand-with-shift branch from b6cf673 to 9c2ef31 Compare December 2, 2024 04:36
@lumixraku lumixraku force-pushed the fix/selection-expand-with-shift branch from 9c2ef31 to 3d58267 Compare December 2, 2024 05:00
@lumixraku lumixraku force-pushed the fix/selection-expand-with-shift branch 2 times, most recently from abcedf0 to 0f9a662 Compare December 2, 2024 06:56
@lumixraku lumixraku force-pushed the fix/selection-expand-with-shift branch 2 times, most recently from e6e4ff6 to 0a3ff06 Compare December 2, 2024 07:29
@lumixraku lumixraku force-pushed the fix/selection-expand-with-shift branch 3 times, most recently from a6ff2fa to a9e8961 Compare December 2, 2024 13:05
@lumixraku lumixraku force-pushed the fix/selection-expand-with-shift branch from a9e8961 to 58c59a9 Compare December 3, 2024 02:59
@lumixraku lumixraku merged commit 22facae into dev Dec 3, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/selection-expand-with-shift branch December 3, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants