Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): facade-namespace & global addEvent #4346

Merged
merged 21 commits into from
Jan 2, 2025
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Dec 20, 2024

univerAPI.Enum.DataValidationType;
univerAPI.Event.CellChanged;
univerAPI.addEvent(univerAPI.Event.SheetCreated, () => {});

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested a review from wzhudev as a code owner December 20, 2024 10:59
Copy link

github-actions bot commented Dec 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 20, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 46 seconds
commit  68376f9
info  For more information, see full report

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 110 lines in your changes missing coverage. Please review.

Project coverage is 33.30%. Comparing base (c5fcf3e) to head (68376f9).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sheets/src/facade/f-univer.ts 0.00% 35 Missing ⚠️
packages/core/src/facade/f-univer.ts 0.00% 26 Missing ⚠️
packages/core/src/facade/f-base.ts 0.00% 15 Missing ⚠️
packages/core/src/facade/f-enum.ts 0.00% 13 Missing ⚠️
packages/core/src/facade/f-event.ts 0.00% 8 Missing ⚠️
packages/sheets/src/facade/f-event.ts 0.00% 3 Missing ⚠️
packages/sheets/src/facade/f-range.ts 0.00% 3 Missing ⚠️
packages/sheets/src/facade/f-workbook.ts 0.00% 3 Missing ⚠️
packages/sheets/src/facade/f-worksheet.ts 0.00% 3 Missing ⚠️
packages/core/src/facade/f-util.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4346      +/-   ##
==========================================
- Coverage   33.33%   33.30%   -0.03%     
==========================================
  Files        2528     2532       +4     
  Lines      130620   130712      +92     
  Branches    29149    29167      +18     
==========================================
  Hits        43540    43540              
- Misses      87080    87172      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 changed the title feat(facade): facade-enums feat(facade): facade-namespace Dec 24, 2024
@weird94 weird94 requested a review from VicKun4937 as a code owner December 31, 2024 07:31
@weird94 weird94 changed the title feat(facade): facade-namespace feat(facade): facade-namespace & global addEvent Dec 31, 2024
packages/core/src/facade/f-event.ts Show resolved Hide resolved
packages/core/src/facade/f-univer.ts Outdated Show resolved Hide resolved
packages/core/src/facade/f-univer.ts Outdated Show resolved Hide resolved
packages/core/src/facade/f-enum.ts Show resolved Hide resolved
@weird94 weird94 merged commit 612c981 into dev Jan 2, 2025
9 checks passed
@weird94 weird94 deleted the feat/facade-enums branch January 2, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants