-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cf): fix cf custom formula range change #4381
base: dev
Are you sure you want to change the base?
Conversation
View Deployment
|
Origin Title: fix(cf): fix cf custom formula range change Title: fix(cf): fix cf custom formula range change close https://github.com/dream-num/univer-pro/issues/3013 All places with formulas in conditional formatting will be affected by selection changes caused by operations such as deleting rows and columns. When testing, please help me check out the function of conditional formatting to see if anything is affected, including undoing and redoing, and also help me walk through it. Pull Request Checklist
|
Playwright test resultsDetails 23 tests across 10 suites |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4381 +/- ##
==========================================
- Coverage 32.61% 32.61% -0.01%
==========================================
Files 2573 2573
Lines 133525 133616 +91
Branches 29706 29733 +27
==========================================
+ Hits 43552 43573 +21
- Misses 89973 90043 +70 ☔ View full report in Codecov by Sentry. |
} | ||
undoMap[`${unitId}_${subUnitId}_${cfId}`].push(item.params as ISetConditionalRuleMutationParams); | ||
}); | ||
Object.values(undoMap).forEach((paramsList) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undo 不需要处理么?
065ba0e
to
f685b69
Compare
f685b69
to
150a212
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests are required for this PR, as this PR introduces an important and error-prone change.
close https://github.com/dream-num/univer-pro/issues/3013
条件格式所有有公式的地方都要受到删除行列等操作造成的选区改变, 测的时候帮忙再稍微点点条件格式的功能 看有没有哪里受到影响,包括撤消重做也帮忙走一走
Pull Request Checklist