Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: try to customize statistic float #4661

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 17, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 4.79042% with 159 lines in your changes missing coverage. Please review.

Project coverage is 32.62%. Comparing base (684db12) to head (094c889).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...src/views/operate-container/SelectionStatistic.tsx 2.01% 146 Missing ⚠️
packages/design/src/themes/theme.ts 0.00% 7 Missing ⚠️
...i/src/views/operate-container/OperateContainer.tsx 20.00% 4 Missing ⚠️
packages/sheets/src/sheets-plugin.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4661      +/-   ##
==========================================
- Coverage   32.67%   32.62%   -0.06%     
==========================================
  Files        2605     2606       +1     
  Lines      135596   135771     +175     
  Branches    30171    30213      +42     
==========================================
- Hits        44307    44290      -17     
- Misses      91289    91481     +192     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the fix/float-statistic branch 3 times, most recently from e6a1f40 to b9c7a3b Compare February 17, 2025 10:08
Copy link

github-actions bot commented Feb 17, 2025

Playwright test results

failed  1 failed
passed  23 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 31 seconds
commit  094c889
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff set force string cell

@lumixraku lumixraku force-pushed the fix/float-statistic branch 2 times, most recently from ce48a84 to 93a58a1 Compare February 17, 2025 12:41
@lumixraku lumixraku marked this pull request as ready for review February 20, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant