feat: add live logs #312
feat: add live logs #312
Conversation
surajgour-d11
force-pushed
the
feat/logs
branch
from
6a45e15 to
8fde14a
Compare
surajgour-d11
force-pushed
the
feat/logs
branch
3 times, most recently
from
fbb7d48 to
567e7f2
Compare
internal/service/logs.go
Outdated
| if response != nil { | ||
| for _, logMessage := range response.Logs { | ||
| fmt.Println(logMessage.GetMessage()) | ||
| lastLogTime = logMessage.GetTimestamp() |
There was a problem hiding this comment.
what if this comes out of order? the lastLogTime will be updated to something before the actual lastLogTime
There was a problem hiding this comment.
Ordering is guaranteed from deployer. But still, we can add > logic to prevent this
internal/service/service.go
Outdated
| } | ||
| } | ||
| attempts++ | ||
| time.Sleep(5 * time.Second) |
There was a problem hiding this comment.
do we need to sleep even if there's no error?
There was a problem hiding this comment.
Sleep is to prevent burst retry if no logs are present for some time.
internal/service/service.go
Outdated
| log.Info("Fetching live logs...") | ||
| } | ||
| select { | ||
| case <-streamCtx.Done(): // Listen for cancellation signal |
There was a problem hiding this comment.
does cancel also send a Done signal?
There was a problem hiding this comment.
Yes, this here sends the done signal
Signed-off-by: surajgour-d11 <[email protected]>
surajgour-d11
force-pushed
the
feat/logs
branch
2 times, most recently
from
3afcb92 to
2e83084
Compare
Signed-off-by: surajgour-d11 <[email protected]>
surajgour-d11
force-pushed
the
feat/logs
branch
from
2e83084 to
ea7f208
Compare
Signed-off-by: surajgour-d11 <[email protected]>
surajgour-d11
force-pushed
the
feat/logs
branch
from
e2555aa to
669fe76
Compare
internal/service/logs.go
Outdated
| if logStreamErr != nil { | ||
| if errors.Is(logStreamErr, context.Canceled) || logStreamErr == io.EOF { | ||
| break | ||
| } else { |
| "VALIDATE": {"FAILED": true}, | ||
| } | ||
|
|
||
| var RetryableStatusCodes = []codes.Code{codes.DeadlineExceeded, codes.Canceled, codes.Unavailable} |
There was a problem hiding this comment.
there is one more. codes.Internal AND description contains "stream terminated by RST_STREAM"
internal/service/service.go
Outdated
| var re retryable.Error | ||
| if errors.As(err, &re) { | ||
| if re.Retryable() { | ||
| log.Info("Connection with backend server lost. Retrying...") |
There was a problem hiding this comment.
i think it was agreed that "Connection with backend server lost." will only come first time. On subsequent retries ,Retrying... should be printed. lets check this with DC once
* chore: refractoring Signed-off-by: surajgour-d11 <[email protected]> * chore: refractoring Signed-off-by: surajgour-d11 <[email protected]> --------- Signed-off-by: surajgour-d11 <[email protected]>
| // DeployService deploys service | ||
| func (e *Service) DeployService(ctx *context.Context, request *serviceProto.DeployServiceRequest) error { | ||
| log.Info("Deploying Service...") |
There was a problem hiding this comment.
Are we not doing this for operate service/component and deploy released service ?
Signed-off-by: surajgour-d11 <[email protected]>
Odin version(x.y.z)
Features
Resources