Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presenter): fix memory leak #3005

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(presenter): fix memory leak #3005

wants to merge 2 commits into from

Conversation

ulfgebhardt
Copy link
Member

@ulfgebhardt ulfgebhardt commented Nov 5, 2024

🍰 Pullrequest

fix memory leak

This PR fixes a memory leak caused by sentry in frontend and presenter.

We observed a memory leak on stage1 where the presenter grew in size till the server exploded.
According to this issue a likely reason is the sentry implementation done lately. The issue states that sentry should never run serverside when utilizing SSR.

The branch is currently checkout out on stage1 to observe

Issues

Todo

  • Check if the solution fixes our memory problems on stage1

@ulfgebhardt
Copy link
Member Author

It works
image
(image taking after several hours, constant uptime check on the presenter, no more ram accumulation - would be several hundred megabyte at least)

@ulfgebhardt ulfgebhardt enabled auto-merge (squash) November 5, 2024 22:00
@ulfgebhardt ulfgebhardt self-assigned this Nov 5, 2024
@mahula mahula added bug Something isn't working devops service:presenter labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devops service:presenter
Projects
Status: 👁️‍🗨️ Ready to review
Development

Successfully merging this pull request may close these issues.

2 participants