Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPCP-27] [DPCP-28] Fix IconButton Size and add Deep Link Protocol #8

Merged

Conversation

angeloreale
Copy link
Contributor

PLEASE REVIEW YOUR OWN PR BEFORE OPENING/UN-DRAFTING IT

[Ticket Title]

[ticket description]

Screenshots/Videocasts/Preview Links

Have you?

  • Reviewed your own PR?
  • Tested your own feature/fix meets Acceptance Criteria?
  • Made sure it passes all checks? (lint, build, integrations, scripts, etc)?
  • Added screenshots? (if relevant)
  • Added unit tests? (if necessary)
  • Added documentation? (if necessary)

If so, THANKS! You can pop a beer/soda.

Please open your PR and ping your colleagues to review it on #web-devs channel.

Also, make sure to remind them on a daily basis during stand-up.

Copy link

vercel bot commented Aug 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oneiros ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2024 1:17pm

Copy link

Add Deep Link protocol

Copy link

Fix Iconbutton size

Comment on lines 176 to 178
// export const DreamPipColors = {
// white: '#ffffff'
// };
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@angeloreale angeloreale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@angeloreale angeloreale merged commit 6911782 into main Aug 4, 2024
6 checks passed
@angeloreale angeloreale deleted the ar/feat/dpcp-27-28--iconbutton-size--deep-link-protocol branch August 4, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant