Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ar/fix/nit open spec default #9

Merged
merged 4 commits into from
Aug 4, 2024
Merged

Ar/fix/nit open spec default #9

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1ea3f9
ar(fix) husky
angeloreale Jul 13, 2024
c113533
Merge branch 'main' of github.com:dreampipcom/oneiros
angeloreale Aug 4, 2024
24ce749
Merge branch 'main' of github.com:dreampipcom/oneiros
angeloreale Aug 4, 2024
1f1d336
ar(fix) nit open windows self
angeloreale Aug 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/atoms/03_Link/Link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@
}: ILink) {
const startApp = useRef<() => void>(() => {});

const isInternal = (link: string) =>

Check warning on line 60 in src/atoms/03_Link/Link.tsx

View workflow job for this annotation

GitHub Actions / oneiros::pr_checks::build 

The 'isInternal' function makes the dependencies of useEffect Hook (at line 114) change on every render. To fix this, wrap the definition of 'isInternal' in its own useCallback() Hook

Check warning on line 60 in src/atoms/03_Link/Link.tsx

View workflow job for this annotation

GitHub Actions / oneiros::pr_checks::lint 

The 'isInternal' function makes the dependencies of useEffect Hook (at line 114) change on every render. To fix this, wrap the definition of 'isInternal' in its own useCallback() Hook
link.startsWith('web+dreampip://') ||
link?.startsWith('https://www.dreampip.com') ||
link?.replace('http://', '').replace('https://', '').startsWith(host) ||
link.startsWith('/');

// deep-linking: protocol
const toProtocol = (link: string): string => {

Check warning on line 67 in src/atoms/03_Link/Link.tsx

View workflow job for this annotation

GitHub Actions / oneiros::pr_checks::build 

The 'toProtocol' function makes the dependencies of useEffect Hook (at line 114) change on every render. To fix this, wrap the definition of 'toProtocol' in its own useCallback() Hook

Check warning on line 67 in src/atoms/03_Link/Link.tsx

View workflow job for this annotation

GitHub Actions / oneiros::pr_checks::lint 

The 'toProtocol' function makes the dependencies of useEffect Hook (at line 114) change on every render. To fix this, wrap the definition of 'toProtocol' in its own useCallback() Hook
if (link.startsWith('https://')) {
return link?.replace('https://', 'web+dreampip://');
}
Expand Down Expand Up @@ -96,7 +96,7 @@
window.removeEventListener('pagehide', preventPopup);
};
startApp.current = () => {
window.open(toProtocol(href));
window.open(toProtocol(href), '_self');
timeout = setTimeout(() => {
// prompt app download
// if (
Expand Down
Loading