MDL-66109 behat: Require newline at EOF

This change enables the gherkinlint rule to require a new line at the end of the file. This change is in keeping with existing Moodle coding style guidelines.
dreasn · May 11, 2020 · 7afd16a · 7afd16a
1 parent 149d80e
commit 7afd16a
Show file tree

Hide file tree

Showing 37 changed files with 38 additions and 37 deletions.
diff --git a/.gherkin-lintrc b/.gherkin-lintrc
@@ -18,5 +18,6 @@
   "no-trailing-spaces": "on",
   "no-unnamed-features": "on",
   "no-unnamed-scenarios": "on",
-  "no-scenario-outlines-without-examples": "on"
+  "no-scenario-outlines-without-examples": "on",
+  "new-line-at-eof": ["on", "yes"]
 }
diff --git a/admin/tests/behat/filter_users.feature b/admin/tests/behat/filter_users.feature
@@ -115,4 +115,4 @@ Feature: An administrator can filter user accounts by role, cohort and other pro
     And I set the field "id_department" to "red"
     And I press "Add filter"
     And I should see "User One"
-    And I should not see "User Two"
+    And I should not see "User Two"
diff --git a/admin/tool/uploadcourse/tests/behat/create.feature b/admin/tool/uploadcourse/tests/behat/create.feature
@@ -104,4 +104,4 @@ Feature: An admin can create courses using a CSV file
     And I should see "Field 2: 1 June 2020"
     And I should see "Field 3: b"
     And I should see "Field 4: Hello"
-    And I should see "Field 5: Some text"
+    And I should see "Field 5: Some text"
diff --git a/admin/tool/uploadcourse/tests/behat/update.feature b/admin/tool/uploadcourse/tests/behat/update.feature
@@ -56,4 +56,4 @@ Feature: An admin can update courses using a CSV file
     And I should see "Field 2: Tuesday, 1 October 2019, 2:00"
     And I should see "Field 3: b"
     And I should see "Field 4: Hello"
-    And I should see "Field 5: Goodbye"
+    And I should see "Field 5: Goodbye"
diff --git a/admin/tool/uploaduser/tests/behat/upload_users.feature b/admin/tool/uploaduser/tests/behat/upload_users.feature
@@ -187,4 +187,4 @@ Feature: Upload users
     Then I should see "2 January 2020" in the "Enrolment starts" "table_row"
     And I should see "12 January 2020" in the "Enrolment ends" "table_row"
     And I click on "Close" "button"
-    And I log out
+    And I log out
diff --git a/backup/util/ui/tests/behat/restore_moodle2_courses_settings.feature b/backup/util/ui/tests/behat/restore_moodle2_courses_settings.feature
@@ -122,4 +122,4 @@ Feature: Restore Moodle 2 course backups with different user data settings
       | Settings |  Include enrolled users | 0 |
     Then I should see "Test database name"
     When I follow "Test database name"
-    Then I should not see "Student entry"
+    Then I should not see "Student entry"
diff --git a/badges/tests/behat/award_badge_groups.feature b/badges/tests/behat/award_badge_groups.feature
@@ -126,4 +126,4 @@ Feature: Award badges with separate groups
     And I follow "Course Badge"
     And I press "Award badge"
     # Teacher 2 shouldn't be able to go further
-    Then I should see "Sorry, but you need to be part of a group to see this page."
+    Then I should see "Sorry, but you need to be part of a group to see this page."
diff --git a/blocks/recentlyaccesseditems/tests/behat/block_recentlyaccesseditems_dashboard.feature b/blocks/recentlyaccesseditems/tests/behat/block_recentlyaccesseditems_dashboard.feature
@@ -36,4 +36,4 @@ Feature: The recently accessed items block allows users to easily access their m
     When  I follow "Test forum name"
     And I follow "Dashboard" in the user menu
     And I change window size to "large"
-    Then I should see "Test forum name" in the "Recently accessed items" "block"
+    Then I should see "Test forum name" in the "Recently accessed items" "block"
diff --git a/contentbank/contenttype/h5p/tests/behat/admin_upload_content.feature b/contentbank/contenttype/h5p/tests/behat/admin_upload_content.feature
@@ -70,4 +70,4 @@ Feature: H5P file upload to content bank for admins
     And I add the "Navigation" block if not present
     And I expand "Site pages" node
     And I click on "Content bank" "link"
-    And I should not see "filltheblanks.h5p"
+    And I should not see "filltheblanks.h5p"
diff --git a/contentbank/tests/behat/access_permissions.feature b/contentbank/tests/behat/access_permissions.feature
@@ -26,4 +26,4 @@ Feature: Access permission to content Bank
 
   Scenario: Editing teachers can't access content bank at system level
     Given I log in as "teacher1"
-    Then "Content bank" "link" should not exist
+    Then "Content bank" "link" should not exist
diff --git a/contentbank/tests/behat/events.feature b/contentbank/tests/behat/events.feature
@@ -70,4 +70,4 @@ Feature: Confirm content bank events are triggered
     And I set the field "Content name" to "New name"
     And I click on "Rename" "button"
     And I navigate to "Reports > Live logs" in site administration
-    Then I should see "Content updated"
+    Then I should see "Content updated"
diff --git a/course/format/singleactivity/tests/behat/edit_format_course.feature b/course/format/singleactivity/tests/behat/edit_format_course.feature
@@ -24,4 +24,4 @@ Feature: Edit format course to Single Activity format
     And I press "Update format"
     Then I should see "Forum" in the "Type of activity" "field"
     And I press "Save and display"
-    And I should see "Adding a new Forum"
+    And I should see "Adding a new Forum"
diff --git a/course/tests/behat/create_delete_course.feature b/course/tests/behat/create_delete_course.feature
@@ -101,4 +101,4 @@ Feature: Test we can both create and delete a course.
     # Redirect
     And I should see the "Course categories and courses" management page
     And I should see "Cat 1" in the "#category-listing" "css_element"
-    And I should see "Test course 2: create another course" in the "#course-listing" "css_element"
+    And I should see "Test course 2: create another course" in the "#course-listing" "css_element"
diff --git a/course/tests/behat/edit_settings.feature b/course/tests/behat/edit_settings.feature
@@ -53,4 +53,4 @@ Feature: Edit course settings
       | Course short name | Edited course shortname |
       | Course summary | Edited course summary |
     And I press "Save and return"
-    Then I should see the "Course categories and courses" management page
+    Then I should see the "Course categories and courses" management page
diff --git a/customfield/field/date/tests/behat/field.feature b/customfield/field/date/tests/behat/field.feature
@@ -102,4 +102,4 @@ Feature: Managers can manage course custom fields date
     And I expand all fieldsets
     Then "#id_customfield_testfield_hour" "css_element" should not be visible
     Then "#id_customfield_testfield_minute" "css_element" should not be visible
-    And I log out
+    And I log out
diff --git a/customfield/tests/behat/unique_field.feature b/customfield/tests/behat/unique_field.feature
@@ -71,4 +71,4 @@ Feature: Uniqueness The course custom fields can be mandatory or not
     And I set the following fields to these values:
       | Test field |  |
     And I press "Save and display"
-    Then I should not see "This value is already used"
+    Then I should not see "This value is already used"
diff --git a/enrol/guest/tests/behat/guest_access.feature b/enrol/guest/tests/behat/guest_access.feature
@@ -47,4 +47,4 @@ Feature: Guest users can auto-enrol themself in courses where guest access is al
     And I set the following fields to these values:
       | Password | moodle_rules |
     And I press "Submit"
-    And I should see "Test forum name"
+    And I should see "Test forum name"
diff --git a/group/tests/behat/create_groups.feature b/group/tests/behat/create_groups.feature
@@ -156,4 +156,4 @@ Feature: Organize students into groups
     And I set the following fields to these values:
       | Group name | Group A |
       | Enrolment key | Abcdef-1 |
-    And I should not see "This enrolment key is already used for another group."
+    And I should not see "This enrolment key is already used for another group."
diff --git a/group/tests/behat/group_description.feature b/group/tests/behat/group_description.feature
@@ -101,4 +101,4 @@ Feature: The description of a group can be viewed by students and teachers
     And I log in as "student2"
     And I am on "Course 1" course homepage
     And I navigate to course participants
-    And ".groupinfobox" "css_element" should not exist
+    And ".groupinfobox" "css_element" should not exist
diff --git a/message/tests/behat/message_manage_notification_preferences.feature b/message/tests/behat/message_manage_notification_preferences.feature
@@ -90,4 +90,4 @@ Feature: Manage notification preferences - Email
     And I open messaging
     And I open messaging settings preferences
     And I should see "Notification preferences"
-    And I should see "Jabber"
+    And I should see "Jabber"
diff --git a/message/tests/behat/message_preferences.feature b/message/tests/behat/message_preferences.feature
@@ -27,4 +27,4 @@ Feature: To be able to see and save user message preferences as admin
     And I log in as "student1"
     And I follow "Preferences" in the user menu
     And I click on "Message preferences" "link"
-    And the field "Email" matches value "0"
+    And the field "Email" matches value "0"
diff --git a/mod/assign/tests/behat/hide_grader.feature b/mod/assign/tests/behat/hide_grader.feature
@@ -93,4 +93,4 @@ Feature: Hide grader identities identity from students
     And I should see "Graded" in the "Grading status" "table_row"
     And I should see "Catch for us the foxes."
     And I should see "Teacher" in the "Graded by" "table_row"
-    And I log out
+    And I log out
diff --git a/mod/data/tests/behat/add_entries.feature b/mod/data/tests/behat/add_entries.feature
@@ -75,4 +75,4 @@ Feature: Users can add entries to database activities
     And I press "Select all"
     And I press "Delete selected"
     And I press "Delete"
-    And I should see "No entries in database"
+    And I should see "No entries in database"
diff --git a/mod/forum/tests/behat/add_forum_inline.feature b/mod/forum/tests/behat/add_forum_inline.feature
@@ -29,4 +29,4 @@ Feature: Add forum activities and discussions utilizing the inline add discussio
     And I am on "Course 1" course homepage
     Then I add a new discussion to "Test forum name" forum inline with:
       | Subject | Post with attachment |
-      | Message | This is the body     |
+      | Message | This is the body     |
diff --git a/mod/forum/tests/behat/favourite_discussion.feature b/mod/forum/tests/behat/favourite_discussion.feature
@@ -45,4 +45,4 @@ Feature: A student can favourite a discussion via the forum settings menu
     And I click on "Discussion 1" action menu
     And I click on "[title='Star this discussion']" "css_element"
     And I click on "Discussion 1" action menu
-    And I click on "[title='Unstar this discussion']" "css_element"
+    And I click on "[title='Unstar this discussion']" "css_element"
diff --git a/mod/forum/tests/behat/inpage_reply.feature b/mod/forum/tests/behat/inpage_reply.feature
@@ -44,4 +44,4 @@ Feature: Students can reply to a discussion in page.
     Then I should see "Discussion contents 1, third message"
     Then I should see "This is a private reply. It is not visible to other participants."
     When I reload the page
-    Then I should see "Discussion contents 1, third message"
+    Then I should see "Discussion contents 1, third message"
diff --git a/mod/lesson/tests/behat/import_fillintheblank_question.feature b/mod/lesson/tests/behat/import_fillintheblank_question.feature
@@ -36,4 +36,4 @@ Feature: In a lesson activity, teacher can import blackboard fill in the blank q
     And I should see "Your answer : frog"
     And I should see "A frog is an amphibian"
     And I press "Continue"
-    And I should see "Congratulations - end of lesson reached"
+    And I should see "Congratulations - end of lesson reached"
diff --git a/mod/lesson/tests/behat/lesson_student_dashboard.feature b/mod/lesson/tests/behat/lesson_student_dashboard.feature
@@ -359,4 +359,4 @@ Feature: In Dashboard, a student can see their current status on all lessons wit
     And I set the following fields to these values:
       | True | 1 |
     And I press "Submit"
-    And I log out
+    And I log out
diff --git a/mod/lesson/tests/behat/teacher_grade_essays.feature b/mod/lesson/tests/behat/teacher_grade_essays.feature
@@ -91,4 +91,4 @@ Feature: In a lesson activity, a non editing teacher can grade essay questions
     Then I should see "Grade essays"
     And I follow "Grade essays"
     And I should not see "Student 1"
-    And I should see "Student 2"
+    And I should see "Student 2"
diff --git a/mod/scorm/tests/behat/completion_condition_require_status.feature b/mod/scorm/tests/behat/completion_condition_require_status.feature
@@ -183,4 +183,4 @@ Feature: Scorm multi-sco completion
     And I log out
     And I log in as "teacher1"
     And I am on "Course 1" course homepage
-    And "Student 1" user has completed "ADV Multi-sco SCORM package" activity
+    And "Student 1" user has completed "ADV Multi-sco SCORM package" activity
diff --git a/mod/scorm/tests/behat/multisco_review_mode.feature b/mod/scorm/tests/behat/multisco_review_mode.feature
@@ -383,4 +383,4 @@ Feature: Scorm multi-sco review mode.
     And I follow "Basic Multi-sco SCORM package"
     Then I should not see "Review mode"
     And I switch to "scorm_object" iframe
-    And I should see "Play of the game"
+    And I should see "Play of the game"
diff --git a/mod/wiki/tests/behat/reset_wiki_comments_tags_files.feature b/mod/wiki/tests/behat/reset_wiki_comments_tags_files.feature
@@ -92,4 +92,4 @@ Feature: Teachers can reset wiki pages, tags and files
     And I follow "Comments"
     And I should not see "Test comment"
     And I follow "Files"
-    And I should see "empty.txt"
+    And I should see "empty.txt"
diff --git a/report/configlog/tests/behat/view_report.feature b/report/configlog/tests/behat/view_report.feature
@@ -37,4 +37,4 @@ Feature: In a report, admin can see configuration changes
       | Setting | initialnumfeedbacks | quiz   | initialnumfeedbacks | 5      | maxsizetodownload   |
       | Setting | maxsizetodownload   | folder | maxsizetodownload   | 2048   | initialnumfeedbacks |
       | Value   | Perth               | core   | defaultcity         | Perth  | maxsizetodownload   |
-      | User    | Admin               | core   | defaultcity         | Perth  | zzzzzzzzz           |
+      | User    | Admin               | core   | defaultcity         | Perth  | zzzzzzzzz           |
diff --git a/theme/boost/tests/behat/settingstabs.feature b/theme/boost/tests/behat/settingstabs.feature
@@ -10,4 +10,4 @@ Feature: Administration nav tabs back
     And I click on "Browse list of users" "link"
     And I should see "New filter"
     When I press the "back" button in the browser
-    Then I should see "Cohorts"
+    Then I should see "Cohorts"
diff --git a/theme/boost/tests/behat/tour_filter.feature b/theme/boost/tests/behat/tour_filter.feature
@@ -32,4 +32,4 @@ Feature: Apply tour filters to a tour for Classic
       | targettype                  | Title             | Content |
       | Display in middle of page   | Welcome           | Welcome to your personal learning space. We'd like to give you a quick tour to show you some of the areas you may find helpful |
     When I am on homepage
-    Then I should see "Welcome to your personal learning space. We'd like to give you a quick tour to show you some of the areas you may find helpful"
+    Then I should see "Welcome to your personal learning space. We'd like to give you a quick tour to show you some of the areas you may find helpful"
diff --git a/user/tests/behat/course_preference.feature b/user/tests/behat/course_preference.feature
@@ -30,4 +30,4 @@ Feature: As a user, "Course preferences" allows me to set my course preference(s
     When I am on "Course 1" course homepage
     And I should not see "Add a resource..." in the "Topic 1" "section"
     And I turn editing mode on
-    Then I should see "Add a resource..." in the "Topic 1" "section"
+    Then I should see "Add a resource..." in the "Topic 1" "section"
diff --git a/user/tests/behat/custom_profile_fields.feature b/user/tests/behat/custom_profile_fields.feature
@@ -212,4 +212,4 @@ Feature: Custom profile fields should be visible and editable by those with the
     And I should not see "notvisible_field"
     And I should not see "notvisible_field_information"
 
-    And I should not see "Edit profile"
+    And I should not see "Edit profile"