Skip to content

Commit

Permalink
PARQUET-1517: [C++] Crypto package updates to match the final spec
Browse files Browse the repository at this point in the history
An initial version of crypto package is merged. This PR updates the crypto code to

conform the signed off specification (wire protocol updates, signature tag creation, AAD support, etc)
improve performance by extending cipher lifecycle to file writing/reading - instead of creating cipher on each encrypt/decrypt operation

Author: Gidon Gershinsky <[email protected]>
Author: Revital1 Eres <[email protected]>
Author: Gidon Gershinsky <[email protected]>
Author: Revital Sur <[email protected]>
Author: thamht4190 <[email protected]>
Author: ggershinsky <[email protected]>

Closes apache#3520 from ggershinsky/p1517-crypto-pack-updates and squashes the following commits:

21ce9d0 <ggershinsky> Merge pull request #6 from revital76/review_comments
ef970e3 <Revital1 Eres> Fix broken line
3ffd606 <Revital1 Eres> Change comment in encryption_internal.h
b570e8e <Revital1 Eres> Fixes following Gidon's comments
535d0e2 <Revital1 Eres> Delete encryption_internal.cc from CMakeLists.txt
9be898e <Revital1 Eres> Address review comments
e784d9d <Gidon Gershinsky> cipher wipe out
abd76a6 <thamht4190> fix build issue on MacOS
24795fa <Gidon Gershinsky> ctr fixes
6c599e9 <thamht4190> fix code style
9fa9ef6 <Gidon Gershinsky> rm old method
9f68cab <Gidon Gershinsky> encryption size delta
4d832d6 <Gidon Gershinsky> stateful encryptor objects
73c8235 <Revital Sur> Fix indentation in crypto.h and crypto.cc
333045b <Revital Sur> Add functions for AAD calculation and adjust code for API changes
aa7b2ab <Gidon Gershinsky> params order
1a99725 <Gidon Gershinsky> cast fix
dfe98ee <Gidon Gershinsky> signed footer encryption
8961544 <Gidon Gershinsky> CTR IV fix
7ecdade <Gidon Gershinsky> iv comment and buffer length
8e7fe90 <Gidon Gershinsky> set or check ciphertext length
03ede65 <Gidon Gershinsky> iv changes and buffer length
  • Loading branch information
ggershinsky authored and wesm committed May 29, 2019
1 parent a833444 commit f199a77
Show file tree
Hide file tree
Showing 4 changed files with 724 additions and 415 deletions.
Loading

0 comments on commit f199a77

Please sign in to comment.