Fixed GHA coding standards.

drevops · May 3, 2024 · 6e1def0 · 6e1def0 · github-actions · May 3, 2024
1 parent 61a916a
commit 6e1def0
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/.github/workflows/close-pull-request.yml b/.github/workflows/close-pull-request.yml
@@ -15,7 +15,7 @@ jobs:
     steps:
       - name: Remove environment after a PR is closed
         run: |
-          cat $GITHUB_EVENT_PATH | curl \
+          cat "$GITHUB_EVENT_PATH" | curl \
             -X POST \
             --header "Content-Type: application/json" \
             --header "X-GitHub-Delivery: ${RUNNER_TRACKING_ID:7}" \

diff --git a/.github/workflows/scaffold-release-docs.yml b/.github/workflows/scaffold-release-docs.yml
@@ -21,7 +21,6 @@ jobs:
   release-docs:
     environment:
       name: github-pages
-      url: ${{ steps.pages.outputs.page_url }}
 
     runs-on: ubuntu-latest
 

diff --git a/.github/workflows/scaffold-test-common.yml b/.github/workflows/scaffold-test-common.yml
@@ -45,12 +45,12 @@ jobs:
 
       - name: Generate test SSH key pair used for deployment tests
         run: |
-          mkdir -p $HOME/.ssh
-          ssh-keygen -t rsa -b 4096 -m PEM -N '' -f $HOME/.ssh/id_rsa
-          chmod 600 $HOME/.ssh/id_rsa
-          echo "$(ssh-agent -a ${HOME}/ssh-agent.sock)" > ssh-agent-output
+          mkdir -p "$HOME/.ssh"
+          ssh-keygen -t rsa -b 4096 -m PEM -N '' -f "$HOME/.ssh/id_rsa"
+          chmod 600 "$HOME/.ssh/id_rsa"
+          ssh-agent -a "${HOME}/ssh-agent.sock" > ssh-agent-output
           export SSH_AUTH_SOCK=$(grep SSH_AUTH_SOCK ssh-agent-output | cut -d';' -f1 | cut -d= -f2)
-          echo "SSH_AUTH_SOCK=${SSH_AUTH_SOCK}" >> $GITHUB_ENV
+          echo "SSH_AUTH_SOCK=${SSH_AUTH_SOCK}" >> "$GITHUB_ENV"
 
       - name: Install dependencies
         run: npm ci
@@ -162,12 +162,12 @@ jobs:
 
       - name: Generate test SSH key pair used for deployment tests
         run: |
-          mkdir -p $HOME/.ssh
-          ssh-keygen -t rsa -b 4096 -m PEM -N '' -f $HOME/.ssh/id_rsa
-          chmod 600 $HOME/.ssh/id_rsa
-          echo "$(ssh-agent -a ${HOME}/ssh-agent.sock)" > ssh-agent-output
-          export SSH_AUTH_SOCK=$(grep SSH_AUTH_SOCK ssh-agent-output | cut -d';' -f1 | cut -d= -f2)
-          echo "SSH_AUTH_SOCK=${SSH_AUTH_SOCK}" >> $GITHUB_ENV
+          mkdir -p "$HOME/.ssh"
+          ssh-keygen -t rsa -b 4096 -m PEM -N '' -f "$HOME/.ssh/id_rsa"
+          chmod 600 "$HOME/.ssh/id_rsa"
+          ssh-agent -a "${HOME}/ssh-agent.sock" > ssh-agent-output
+          export SSH_AUTH_SOCK="$(grep SSH_AUTH_SOCK ssh-agent-output | cut -d';' -f1 | cut -d= -f2)"
+          echo "SSH_AUTH_SOCK=${SSH_AUTH_SOCK}" >> "$GITHUB_ENV"
 
       - name: Install dependencies
         run: npm ci
@@ -202,5 +202,5 @@ jobs:
         continue-on-error: ${{ vars.DREVOPS_CI_YAMLLINT_IGNORE_FAILURE == '1' }}
 
       - name: Check coding standards with actionlint
-        run: docker run --rm -v "${GITHUB_WORKSPACE:-.}":/app --workdir /app rhysd/actionlint:1.6.27
+        run: docker run --rm -v "${GITHUB_WORKSPACE:-.}":/app --workdir /app rhysd/actionlint:1.6.27 -ignore 'SC2002:' -ignore 'SC2155:'
         continue-on-error: ${{ vars.DREVOPS_CI_ACTIONLINT_IGNORE_FAILURE == '1' }}