Lint.

drevops · Apr 17, 2024 · e1a6b60 · e1a6b60 · github-actions · Apr 17, 2024
1 parent 7a408d0
commit e1a6b60
Show file tree

Hide file tree

Showing 24 changed files with 108 additions and 24 deletions.
diff --git a/scripts/drevops/deploy-docker.sh b/scripts/drevops/deploy-docker.sh
@@ -39,7 +39,11 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in docker; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+#shellcheck disable=SC2043
+for cmd in docker; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 info "Started DOCKER deployment."
 

diff --git a/scripts/drevops/deploy-lagoon.sh b/scripts/drevops/deploy-lagoon.sh
@@ -102,7 +102,10 @@ if ! command -v lagoon >/dev/null || [ -n "${DREVOPS_LAGOONCLI_FORCE_INSTALL}" ]
   export PATH="${PATH}:${DREVOPS_LAGOONCLI_PATH}"
 fi
 
-for cmd in lagoon curl; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+for cmd in lagoon curl; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 note "Configuring Lagoon instance."
 #shellcheck disable=SC2218

diff --git a/scripts/drevops/deploy-webhook.sh b/scripts/drevops/deploy-webhook.sh
@@ -31,7 +31,11 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in curl; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+#shellcheck disable=SC2043
+for cmd in curl; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 info "Started WEBHOOK deployment."
 

diff --git a/scripts/drevops/doctor.sh b/scripts/drevops/doctor.sh
@@ -72,7 +72,10 @@ fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 warn() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[33m[WARN] %s\033[0m\n" "${1}" || printf "[WARN] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in docker pygmy ahoy; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+for cmd in docker pygmy ahoy; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 #
 # Main entry point.

diff --git a/scripts/drevops/download-db-acquia.sh b/scripts/drevops/download-db-acquia.sh
@@ -55,7 +55,10 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in php curl gunzip; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+for cmd in php curl gunzip; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 info "Started database dump download from Acquia."
 

diff --git a/scripts/drevops/download-db-curl.sh b/scripts/drevops/download-db-curl.sh
@@ -30,7 +30,11 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in curl; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+#shellcheck disable=SC2043
+for cmd in curl; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 info "Started database dump download from CURL."
 

diff --git a/scripts/drevops/download-db-docker-registry.sh b/scripts/drevops/download-db-docker-registry.sh
@@ -33,7 +33,11 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in docker; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+#shellcheck disable=SC2043
+for cmd in docker; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 info "Started Docker data image download."
 

diff --git a/scripts/drevops/download-db-ftp.sh b/scripts/drevops/download-db-ftp.sh
@@ -41,7 +41,11 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in curl; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+#shellcheck disable=SC2043
+for cmd in curl; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 # Check all required values.
 [ -z "${DREVOPS_DB_DOWNLOAD_FTP_USER}" ] && fail "Missing required value for DREVOPS_DB_DOWNLOAD_FTP_USER." && exit 1

diff --git a/scripts/drevops/download-db-lagoon.sh b/scripts/drevops/download-db-lagoon.sh
@@ -76,7 +76,10 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in ssh rsync; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+for cmd in ssh rsync; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 info "Started database dump download from Lagoon."
 

diff --git a/scripts/drevops/export-db-docker.sh b/scripts/drevops/export-db-docker.sh
@@ -33,7 +33,11 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in docker; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+#shellcheck disable=SC2043
+for cmd in docker; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 info "Started Docker database image export."
 

diff --git a/scripts/drevops/export-db.sh b/scripts/drevops/export-db.sh
@@ -25,7 +25,11 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in docker; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+#shellcheck disable=SC2043
+for cmd in docker; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 info "Started database export."
 

diff --git a/scripts/drevops/github-labels.sh b/scripts/drevops/github-labels.sh
@@ -35,7 +35,11 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in curl; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+#shellcheck disable=SC2043
+for cmd in curl; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 # Array of labels to create. If DELETE_EXISTING_LABELS=1, the labels list will
 # be exactly as below, otherwise labels below will be added to existing ones.

diff --git a/scripts/drevops/login-docker.sh b/scripts/drevops/login-docker.sh
@@ -29,7 +29,11 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in docker; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+#shellcheck disable=SC2043
+for cmd in docker; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 # Check all required values.
 [ -z "${DOCKER_REGISTRY}" ] && echo "Missing required value for DOCKER_REGISTRY." && exit 1

diff --git a/scripts/drevops/mirror-code.sh b/scripts/drevops/mirror-code.sh
@@ -44,7 +44,10 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in git rsync; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+for cmd in git rsync; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 info "Started code mirroring."
 

diff --git a/scripts/drevops/notify-github.sh b/scripts/drevops/notify-github.sh
@@ -43,7 +43,10 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in php curl; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+for cmd in php curl; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 [ -z "${DREVOPS_NOTIFY_GITHUB_TOKEN}" ] && fail "Missing required value for DREVOPS_NOTIFY_GITHUB_TOKEN" && exit 1
 [ -z "${DREVOPS_NOTIFY_REPOSITORY}" ] && fail "Missing required value for DREVOPS_NOTIFY_REPOSITORY" && exit 1

diff --git a/scripts/drevops/notify-jira.sh b/scripts/drevops/notify-jira.sh
@@ -53,7 +53,10 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in php curl; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+for cmd in php curl; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 [ -z "${DREVOPS_NOTIFY_JIRA_USER}" ] && fail "Missing required value for DREVOPS_NOTIFY_JIRA_USER" && exit 1
 [ -z "${DREVOPS_NOTIFY_JIRA_TOKEN}" ] && fail "Missing required value for DREVOPS_NOTIFY_JIRA_TOKEN" && exit 1

diff --git a/scripts/drevops/notify-newrelic.sh b/scripts/drevops/notify-newrelic.sh
@@ -52,7 +52,11 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in curl; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+#shellcheck disable=SC2043
+for cmd in curl; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 [ -z "${DREVOPS_NOTIFY_NEWRELIC_PROJECT}" ] && fail "Missing required value for DREVOPS_NOTIFY_NEWRELIC_PROJECT" && exit 1
 [ -z "${DREVOPS_NOTIFY_NEWRELIC_APIKEY}" ] && fail "Missing required value for DREVOPS_NOTIFY_NEWRELIC_APIKEY" && exit 1

diff --git a/scripts/drevops/reset.sh b/scripts/drevops/reset.sh
@@ -18,7 +18,11 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in git; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+#shellcheck disable=SC2043
+for cmd in git; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 is_hard_reset="$([ "${1:-}" == "hard" ] && echo "1" || echo "0")"
 

diff --git a/scripts/drevops/setup-ssh.sh b/scripts/drevops/setup-ssh.sh
@@ -33,7 +33,10 @@ pass() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\033[31m[FAIL] %s\033[0m\n" "${1}" || printf "[FAIL] %s\n" "${1}"; }
 # @formatter:on
 
-for cmd in ssh-keygen ssh-add; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+for cmd in ssh-keygen ssh-add; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 info "Started SSH setup."
 

diff --git a/scripts/drevops/task-copy-db-acquia.sh b/scripts/drevops/task-copy-db-acquia.sh
@@ -71,7 +71,11 @@ extract_json_value() {
 }
 
 # Pre-flight checks.
-for cmd in curl; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+#shellcheck disable=SC2043
+for cmd in curl; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 # Check that all required variables are present.
 [ -z "${DREVOPS_ACQUIA_KEY}" ] && fail "Missing value for DREVOPS_ACQUIA_KEY." && exit 1

diff --git a/scripts/drevops/task-copy-files-acquia.sh b/scripts/drevops/task-copy-files-acquia.sh
@@ -50,7 +50,10 @@ fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 # @formatter:on
 
 # Pre-flight checks.
-for cmd in php curl; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+for cmd in php curl; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 info "Started database copying between environments in Acquia."
 

diff --git a/scripts/drevops/task-custom-lagoon.sh b/scripts/drevops/task-custom-lagoon.sh
@@ -86,7 +86,10 @@ if ! command -v lagoon >/dev/null || [ -n "${DREVOPS_LAGOONCLI_FORCE_INSTALL}" ]
   export PATH="${PATH}:${DREVOPS_LAGOONCLI_PATH}"
 fi
 
-for cmd in curl lagoon; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+for cmd in curl lagoon; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 note "Configuring Lagoon instance."
 #shellcheck disable=SC2218

diff --git a/scripts/drevops/task-purge-cache-acquia.sh b/scripts/drevops/task-purge-cache-acquia.sh
@@ -50,7 +50,10 @@ fail() { [ "${TERM:-}" != "dumb" ] && tput colors >/dev/null 2>&1 && printf "\03
 # @formatter:on
 
 # Pre-flight checks.
-for cmd in php curl; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+for cmd in php curl; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 info "Started cache purging in Acquia."
 

diff --git a/scripts/drevops/update-scaffold.sh b/scripts/drevops/update-scaffold.sh
@@ -24,7 +24,10 @@ DREVOPS_INSTALLER_URL="${DREVOPS_INSTALLER_URL:-https://install.drevops.com}"
 export DREVOPS_INSTALLER_URL
 export DREVOPS_INSTALL_COMMIT
 
-for cmd in php curl; do command -v ${cmd} >/dev/null || { fail "Command ${cmd} is not available"; exit 1; }; done
+for cmd in php curl; do command -v ${cmd} >/dev/null || {
+  fail "Command ${cmd} is not available"
+  exit 1
+}; done
 
 curl -L "${DREVOPS_INSTALLER_URL}"?"$(date +%s)" >/tmp/install
 php /tmp/install --quiet