Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1328] Added support for custom configuration location via DRUPAL_CONFIG_PATH. #1330

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Jun 4, 2024

Checklist before requesting a review

closes #1328

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@tannguyen04 tannguyen04 changed the title Feature/add drupal config sync env var Added Drupal config sync env var Jun 4, 2024
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 05:18 Inactive
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.25%. Comparing base (efb3308) to head (52bed6a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1330      +/-   ##
===========================================
- Coverage    67.12%   57.25%   -9.87%     
===========================================
  Files           41       41              
  Lines         3051     3051              
===========================================
- Hits          2048     1747     -301     
- Misses        1003     1304     +301     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to commit June 4, 2024 08:27 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 08:37 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 09:21 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 09:30 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 09:35 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 09:42 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 09:47 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 09:50 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 10:09 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 10:15 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 10:18 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 10:22 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 10:24 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 10:30 Inactive
@tannguyen04 tannguyen04 force-pushed the feature/add-drupal-config-sync-env-var branch from c42ac95 to 92502c0 Compare June 4, 2024 20:01
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 20:02 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 20:09 Inactive
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 20:16 Inactive
@tannguyen04 tannguyen04 marked this pull request as ready for review June 4, 2024 20:45
@tannguyen04
Copy link
Contributor Author

Hi @AlexSkrypnyk
I saw you are using DRUPAL_CONFIG_PATH in provision.sh so I use DRUPAL_CONFIG_PATH instead of DRUPAL_CONFIG_DIRECTORY from https://github.com/drevops/scaffold/pull/1329/files

@tannguyen04 tannguyen04 marked this pull request as draft June 4, 2024 20:48
@AlexSkrypnyk AlexSkrypnyk marked this pull request as ready for review June 4, 2024 21:13
@AlexSkrypnyk AlexSkrypnyk marked this pull request as draft June 4, 2024 21:14
@tannguyen04 tannguyen04 marked this pull request as ready for review June 4, 2024 21:36
@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/add-drupal-config-sync-env-var branch from ec9430c to 52bed6a Compare June 4, 2024 22:17
@AlexSkrypnyk AlexSkrypnyk changed the title Added Drupal config sync env var [#1328] Added support for custom configuration location via DRUPAL_CONFIG_PATH. Jun 4, 2024
@AlexSkrypnyk AlexSkrypnyk enabled auto-merge (rebase) June 4, 2024 22:19
@AlexSkrypnyk AlexSkrypnyk added PR: AUTOMERGE Pull request has been approved and set to automerge PR: Ready to be merged Pull request is ready to be merged (assigned after testing is complete) labels Jun 4, 2024
@github-actions github-actions bot temporarily deployed to commit June 4, 2024 22:19 Inactive
@AlexSkrypnyk AlexSkrypnyk added this to the 1.22 milestone Jun 4, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit 0121bbf into develop Jun 4, 2024
20 of 21 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/add-drupal-config-sync-env-var branch June 4, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: AUTOMERGE Pull request has been approved and set to automerge PR: Ready to be merged Pull request is ready to be merged (assigned after testing is complete)
Projects
Status: Released in 1.20
Development

Successfully merging this pull request may close these issues.

Allow to configure site configuration location via environment variable
2 participants