Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1306, #1336] Updated Chrome image #1344

Closed

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Aug 1, 2024

Checklist before requesting a review

closes #1306
closes #1336

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.12%. Comparing base (d21e512) to head (7882dfd).
Report is 57 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1344   +/-   ##
========================================
  Coverage    67.12%   67.12%           
========================================
  Files           41       41           
  Lines         3051     3051           
========================================
  Hits          2048     2048           
  Misses        1003     1003           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to commit August 1, 2024 09:31 Inactive
@github-actions github-actions bot temporarily deployed to commit August 2, 2024 07:24 Inactive
@tannguyen04 tannguyen04 changed the title Init Updated Chrome image Aug 2, 2024
@tannguyen04 tannguyen04 marked this pull request as ready for review August 2, 2024 07:47
@github-actions github-actions bot temporarily deployed to commit August 6, 2024 02:54 Inactive
@github-actions github-actions bot temporarily deployed to commit August 6, 2024 02:58 Inactive
@tannguyen04
Copy link
Contributor Author

tannguyen04 commented Aug 6, 2024

Hi @AlexSkrypnyk

Our repo is using selenium2 driver from Lullabot which using w3c mode by default.

Screenshot 2024-08-06 at 9 53 14 AM Screenshot 2024-08-06 at 10 06 26 AM

I just done 3 things with this PR.

  1. Pin 127.0 as latest version for selenium standalone chromium
  2. Rewrite Mink config to read more easier.
  3. Move from Selniarm to Seleinum as the project was merged

@github-actions github-actions bot temporarily deployed to commit August 6, 2024 03:16 Inactive
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please remove docker compose override file and update tests.
  2. Please remove the added test.

@AlexSkrypnyk AlexSkrypnyk changed the title Updated Chrome image [#1306, #1336] Updated Chrome image Aug 7, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title [#1306, #1336] Updated Chrome image #1306, #1336 Updated Chrome image Aug 7, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title #1306, #1336 Updated Chrome image #1336 Updated Chrome image Aug 7, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title #1336 Updated Chrome image [#1306, #1336] Updated Chrome image Aug 7, 2024
@AlexSkrypnyk AlexSkrypnyk added PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request PR: DO NOT MERGE Do not merge this pull request labels Aug 14, 2024
@AlexSkrypnyk
Copy link
Member

Closed in favour of #1345

@AlexSkrypnyk AlexSkrypnyk deleted the feature/selenium-standalone-chrome-updates branch August 30, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: DO NOT MERGE Do not merge this pull request PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from seleniarm to seleinum as the project was merged
2 participants