remove default arg from object

drexlerd · Feb 17, 2024 · e2357a3 · e2357a3
1 parent aac5cd0
commit e2357a3
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/benchmarks/utils.cpp b/benchmarks/utils.cpp
@@ -10,7 +10,7 @@ loki::pddl::AtomList create_atoms(
     auto objects = loki::pddl::ObjectList();
     for (size_t i = 1; i <= num_objects; ++i) {
         objects.push_back(factories.objects.get_or_create<loki::pddl::ObjectImpl>(
-            ("object_" + std::to_string(i)))
+            ("object_" + std::to_string(i)), pddl::TypeList())
         );
     }
 

diff --git a/include/loki/domain/pddl/object.hpp b/include/loki/domain/pddl/object.hpp
@@ -37,7 +37,7 @@ class ObjectImpl : public Base<ObjectImpl> {
     std::string m_name;
     TypeList m_types;
 
-    ObjectImpl(int identifier, std::string name, TypeList types={});
+    ObjectImpl(int identifier, std::string name, TypeList types);
 
     // Give access to the constructor.
     template<typename HolderType, ElementsPerSegment N>

diff --git a/src/domain/pddl/parser/constants.cpp b/src/domain/pddl/parser/constants.cpp
@@ -51,7 +51,7 @@ static void insert_context_information(const pddl::Object& constant, const domai
 static pddl::Object parse_constant_definition(const domain::ast::Name& node, const pddl::TypeList& type_list, Context& context) {
     const auto constant = context.factories.objects.get_or_create<pddl::ObjectImpl>(
         parse(node), 
-        pddl::TypeList{type_list});
+        type_list);
     test_multiple_definition(constant, node, context);
     insert_context_information(constant, node, context);
     return constant;

diff --git a/tests/unit/common/pddl/persistent_factory.cpp b/tests/unit/common/pddl/persistent_factory.cpp
@@ -28,16 +28,16 @@ TEST(LokiTests, PersistentFactoryTest) {
     EXPECT_EQ(factory.size(), 0);
 
     // Test uniqueness: insert the same element twice
-    const auto object_0_0 = factory.get_or_create<pddl::ObjectImpl>("object_0");
+    const auto object_0_0 = factory.get_or_create<pddl::ObjectImpl>("object_0", pddl::TypeList());
     EXPECT_EQ(factory.size(), 1);
     EXPECT_EQ(object_0_0->get_identifier(), 0);
     EXPECT_EQ(object_0_0->get_name(), "object_0");
 
-    const auto object_0_1 = factory.get_or_create<pddl::ObjectImpl>("object_0");
+    const auto object_0_1 = factory.get_or_create<pddl::ObjectImpl>("object_0", pddl::TypeList());
     EXPECT_EQ(factory.size(), 1);
     EXPECT_EQ(object_0_0, object_0_1);
 
-    const auto object_1 = factory.get_or_create<pddl::ObjectImpl>("object_1");
+    const auto object_1 = factory.get_or_create<pddl::ObjectImpl>("object_1", pddl::TypeList());
     EXPECT_EQ(factory.size(), 2);
     EXPECT_NE(object_0_0, object_1);
     EXPECT_EQ(object_1->get_identifier(), 1);

diff --git a/tests/unit/common/pddl/reference.cpp b/tests/unit/common/pddl/reference.cpp
@@ -26,8 +26,8 @@ namespace loki::domain::tests {
 
 TEST(LokiTests, ReferenceTest) {
     PersistentFactory<pddl::ObjectImpl, 2> factory;
-    const auto object_0 = factory.get_or_create<pddl::ObjectImpl>("object_0");
-    const auto object_1 = factory.get_or_create<pddl::ObjectImpl>("object_1");
+    const auto object_0 = factory.get_or_create<pddl::ObjectImpl>("object_0", pddl::TypeList());
+    const auto object_1 = factory.get_or_create<pddl::ObjectImpl>("object_1", pddl::TypeList());
 
     ReferencedPDDLObjects references;
     EXPECT_TRUE(!references.exists(object_0));