frank/usermap #14
Merged
frank/usermap #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordy25519
reviewed
Mar 18, 2024
| } | ||
|
|
||
| pub fn get(&self, pubkey: &str) -> Option<User> { | ||
| self.usermap.get(pubkey).map(|user| user.value().clone()) |
There was a problem hiding this comment.
is it possible to return &User? the caller can clone if they need
There was a problem hiding this comment.
without using Cow i don't think so and i'd really rather not use Cow, cloning 4.3kb shouldn't be that expensive
| pub struct Usermap { | ||
| subscribed: bool, | ||
| subscription: WebsocketProgramAccountSubscriber, | ||
| usermap: Arc<DashMap<String, User>>, |
There was a problem hiding this comment.
is String helpful here?
Suggested change
| usermap: Arc<DashMap<String, User>>, | |
| usermap: Arc<DashMap<Pubkey, User>>, |
There was a problem hiding this comment.
the pubkeys come out of the events as strings, i think keeping it string makes sense
| if let Some(update) = event.as_any().downcast_ref::<ProgramAccountUpdate<User>>() { | ||
| let user_data_and_slot = update.data_and_slot.clone(); | ||
| let user_pubkey = update.pubkey.to_string(); | ||
| if update.data_and_slot.slot > latest_slot.load(Ordering::Relaxed) { |
There was a problem hiding this comment.
maybe >= ? so updates from different user in the same slot should both go through
There was a problem hiding this comment.
the data updates will still go through, it just won't go to the effort of updating the latest slot if it's the same slot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.