Add method to forcefully include market accounts with TransactionBuilder #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordy25519
force-pushed
the
fix/38-again
branch
from
8257c77 to
6aeb3f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #38
motivation:
drift needs to read/write market accounts for open positions/orders e.g. for margin checks.
currently, a tx is built with the market accounts using synced User data but there can be race conditions and so the constructed tx is missing necessary accounts vs. onchain when it is broadcast.
this PR allows to force some market accounts to be included when building a tx, which can allow the tx to land successfully (when it otherwise wouldn't have- due to the sync issues)
replicates similar behaviour in the Ts sdk.