-
-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MySql] Add support for fulltext
search with MATCH AGAINST function
#1030
base: main
Are you sure you want to change the base?
Conversation
Added a new `fulltextIndex` function and a new configuration `fulltext` for Drizzle-kit to pick up (Needs to be implemented in Drizzle-kit).
Implemented a `match` function that returns a class with an `against` method for fulltext match-against support
I will add drizzle-kit support for that and then merge this PR. Will keep you updated here |
I was trying to change the base branch for this PR but it's apparently not possible |
Would love to see this merged! |
Hi, anyone knows what's the status on this PR? Would love to use this feature on a planetscale db |
Are there plans on merging this pull request? |
Any updates on this? Currently having to use planetscale branching, and manually adding fulltext indexes through the planetscale console on every schema change that get's merged to production. |
Sadly this is a gamebreaker for me and I will need to move to different orm until this is merged... |
I'd also love to see this update merged. |
@AndriiSherman has support for this landed in drizzle-kit? You don't accept pull requests in your drizzle-kit-mirror repository right? |
Any news? |
plan anytime soon to merge this PR? I'd love to use this feature :) |
How about this ? @Angelelz select()
.from(users)
.where(
match(users.name, users.bio)
- .against("drizzle*", {
- mode: "boolean"
- }));
+ .against("drizzle*", "boolean")
+ ); That would be closer to SQL syntax. Maybe the variable naming should be more like in MySQL for example select()
.from(users)
.where(
match(users.name, users.bio)
- .against("drizzle*", {
- mode: "boolean"
- }));
+ .against("drizzle*", "inBooleanMode")
+ ); or select()
.from(users)
.where(
match(users.name, users.bio)
- .against("drizzle*", {
- mode: "boolean"
- }));
+ .against("drizzle*", "booleanMode")
+ ); |
+1 |
This PR aims to complete the implementation started in this PR.
fulltextIndex
function for the creation offulltext index
.match
function that returns a class with anagainst
method to be able to use the builder pattern as requested in this commentThe user should now be able to use it as follows:
Please note that the
fulltextIndex
function would address #1018 but won't do anything on it's own as it needs to be supported by Drizzle-kit when creating a migration.