Add blob column type to singlestore #3739
Open
+267
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rodriguespn
changed the title
| * It's recommended to use `text('...', { mode: 'json' })` instead of `blob` in JSON mode, because it supports JSON functions: | ||
| * >All JSON functions currently throw an error if any of their arguments are BLOBs because BLOBs are reserved for a future enhancement in which BLOBs will store the binary encoding for JSON. | ||
| * | ||
| * https://www.sqlite.org/json1.html |
There was a problem hiding this comment.
copy-pasted sqlite comments, should be removed
| if (config?.mode === 'json') { | ||
| return new SingleStoreBlobJsonBuilder(name); | ||
| } | ||
| if (config?.mode === 'bigint') { |
There was a problem hiding this comment.
Why do we need BigInt mode for blobs? We should support string and maybe buffer modes, but we can start by just mapping string data
| : SingleStoreBlobJsonBuilderInitial<TName>; | ||
| export function blob(a?: string | BlobConfig, b?: BlobConfig) { | ||
| const { name, config } = getColumnNameAndConfig<BlobConfig | undefined>(a, b); | ||
| if (config?.mode === 'json') { |
There was a problem hiding this comment.
Why do we need JSON mode for blobs? We should support string and maybe buffer modes, but we can start by just mapping string data
| @@ -163,7 +169,7 @@ const usersMySchemaTable = mySchema.table('userstest', { | |||
| id: serial('id').primaryKey(), | |||
| name: text('name').notNull(), | |||
| verified: boolean('verified').notNull().default(false), | |||
| jsonb: json('jsonb').$type<string[]>(), | |||
There was a problem hiding this comment.
We don't need to remove json type from tests here. Blob should be tested separately. You can check MySQL varbinary as long as SingleStore blob should be pretty the same as MySQL varbinary: https://docs.singlestore.com/cloud/reference/sql-reference/data-types/blob-types/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Blob column type to SingleStore
The blob implementation is very similar to the SQLite
drizzle-orm/columns/blob.ts