Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MySQL] feat(mysql): Support vectorIndex and secondaryEngineAttribute #3778

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions drizzle-kit/src/serializer/mysqlSchema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ const index = object({
name: string(),
columns: string().array(),
isUnique: boolean(),
vector: boolean().optional(),
using: enumType(['btree', 'hash']).optional(),
algorithm: enumType(['default', 'inplace', 'copy']).optional(),
lock: enumType(['default', 'none', 'shared', 'exclusive']).optional(),
secondaryEngineAttribute: string().optional(),
}).strict();

const fk = object({
Expand Down Expand Up @@ -222,19 +224,19 @@ export type ViewSquashed = TypeOf<typeof viewSquashed>;
export const MySqlSquasher = {
squashIdx: (idx: Index) => {
index.parse(idx);
return `${idx.name};${idx.columns.join(',')};${idx.isUnique};${idx.using ?? ''};${idx.algorithm ?? ''};${
idx.lock ?? ''
}`;
return `${idx.name};${idx.columns.join(',')};${idx.isUnique};${idx.vector};${idx.using ?? ''};${idx.algorithm ?? ''};${idx.lock ?? ''};${idx.secondaryEngineAttribute ?? ''}`;
},
unsquashIdx: (input: string): Index => {
const [name, columnsString, isUnique, using, algorithm, lock] = input.split(';');
const [name, columnsString, isUnique, vector, using, algorithm, lock, secondaryEngineAttribute] = input.split(';');
const destructed = {
name,
columns: columnsString.split(','),
isUnique: isUnique === 'true',
vector: vector === 'true',
using: using ? using : undefined,
algorithm: algorithm ? algorithm : undefined,
lock: lock ? lock : undefined,
secondaryEngineAttribute: secondaryEngineAttribute ? secondaryEngineAttribute : undefined,
};
return index.parse(destructed);
},
Expand Down
2 changes: 2 additions & 0 deletions drizzle-kit/src/serializer/mysqlSerializer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -364,9 +364,11 @@ export const generateMySqlSnapshot = (
name,
columns: indexColumns,
isUnique: value.config.unique ?? false,
vector: value.config.vector ?? false,
using: value.config.using,
algorithm: value.config.algorythm,
lock: value.config.lock,
secondaryEngineAttribute: value.config.secondaryEngineAttribute,
};
});

Expand Down
7 changes: 4 additions & 3 deletions drizzle-kit/src/sqlgenerator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3480,10 +3480,10 @@ class CreateMySqlIndexConvertor extends Convertor {

convert(statement: JsonCreateIndexStatement): string {
// should be changed
const { name, columns, isUnique } = MySqlSquasher.unsquashIdx(
const { name, columns, isUnique, vector, secondaryEngineAttribute } = MySqlSquasher.unsquashIdx(
statement.data,
);
const indexPart = isUnique ? 'UNIQUE INDEX' : 'INDEX';
const indexPart = isUnique ? 'UNIQUE INDEX' : vector ? 'VECTOR INDEX' : 'INDEX';

const uniqueString = columns
.map((it) => {
Expand All @@ -3494,8 +3494,9 @@ class CreateMySqlIndexConvertor extends Convertor {
: `\`${it}\``;
})
.join(',');
const secondaryEngineAttributeString = secondaryEngineAttribute ? ` SECONDARY_ENGINE_ATTRIBUTE='${secondaryEngineAttribute}'` : '';

return `CREATE ${indexPart} \`${name}\` ON \`${statement.tableName}\` (${uniqueString});`;
return `CREATE ${indexPart} \`${name}\` ON \`${statement.tableName}\` (${uniqueString})${secondaryEngineAttributeString};`;
}
}

Expand Down
90 changes: 89 additions & 1 deletion drizzle-kit/tests/mysql-generated.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { SQL, sql } from 'drizzle-orm';
import { int, mysqlTable, text } from 'drizzle-orm/mysql-core';
import { bigint, customType, index, int, mysqlTable, text, varchar, vectorIndex } from 'drizzle-orm/mysql-core';
import { expect, test } from 'vitest';
import { diffTestSchemasMysql } from './schemaDiffer';

Expand Down Expand Up @@ -1288,3 +1288,91 @@ test('generated as string: change generated constraint', async () => {
"ALTER TABLE `users` ADD `gen_name` text GENERATED ALWAYS AS (`users`.`name` || 'hello') VIRTUAL;",
]);
});

export const vector = customType<{
data: string;
config: { length: number };
configRequired: true;
}>({
dataType(config) {
return `VECTOR(${config.length})`;
},
});

test.only('generated as string: vector index and secondaryEngineAttribute', async () => {
const from = {};
const to = {
users: mysqlTable('users', {
id: bigint({ mode: "bigint" }).autoincrement().primaryKey(),
name: varchar({ length: 255 }).notNull(),
embedding: vector("embedding", { length: 3 }),
}, (table) => {
return {
idx_embedding: vectorIndex({
name: "idx_embedding",
secondaryEngineAttribute: '{"type":"spann", "distance":"cosine"}',
}).on(table.embedding),
};
}),
};

const { statements, sqlStatements } = await diffTestSchemasMysql(
from,
to,
[],
);

expect(statements).toStrictEqual([
{
type: "create_table",
tableName: "users",
schema: undefined,
columns: [
{
name: "id",
type: "bigint",
primaryKey: false,
notNull: true,
autoincrement: true,
},
{
name: "name",
type: "varchar(255)",
primaryKey: false,
notNull: true,
autoincrement: false,
},
{
name: "embedding",
type: "VECTOR(3)",
primaryKey: false,
notNull: false,
autoincrement: false,
},
],
compositePKs: ["users_id;id"],
compositePkName: "users_id",
uniqueConstraints: [],
internals: { tables: {}, indexes: {} },
checkConstraints: [],
},
{
type: "create_index",
tableName: "users",
data: 'idx_embedding;embedding;false;true;;;;{"type":"spann", "distance":"cosine"}',
schema: undefined,
internal: { tables: {}, indexes: {} },
},
]);

expect(sqlStatements).toStrictEqual([
`CREATE TABLE \`users\` (
\`id\` bigint AUTO_INCREMENT NOT NULL,
\`name\` varchar(255) NOT NULL,
\`embedding\` VECTOR(3),
CONSTRAINT \`users_id\` PRIMARY KEY(\`id\`)
);
`,
'CREATE VECTOR INDEX `idx_embedding` ON `users` (`embedding`) SECONDARY_ENGINE_ATTRIBUTE=\'{"type":"spann", "distance":"cosine"}\';',
]);
});
29 changes: 24 additions & 5 deletions drizzle-orm/src/mysql-core/indexes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import type { SQL } from '~/sql/sql.ts';
import type { AnyMySqlColumn, MySqlColumn } from './columns/index.ts';
import type { MySqlTable } from './table.ts';

export type MysqlIndexMethod = 'btree' | 'hash' | 'hnsw' | (string & {});

interface IndexConfig {
name: string;

Expand All @@ -13,6 +15,11 @@ interface IndexConfig {
*/
unique?: boolean;

/**
* If true, the index will be created as `create vector index` instead of `create index`.
*/
vector?: boolean;

/**
* If set, the index will be created as `create index ... using { 'btree' | 'hash' }`.
*/
Expand All @@ -27,17 +34,22 @@ interface IndexConfig {
* If set, adds locks to the index creation.
*/
lock?: 'default' | 'none' | 'shared' | 'exclusive';

secondaryEngineAttribute?: string;
}

export type IndexColumn = MySqlColumn | SQL;

export class IndexBuilderOn {
static readonly [entityKind]: string = 'MySqlIndexBuilderOn';

constructor(private name: string, private unique: boolean) {}
constructor(private name: string | Omit<IndexConfig, 'columns'>, private unique: boolean) { }

on(...columns: [IndexColumn, ...IndexColumn[]]): IndexBuilder {
return new IndexBuilder(this.name, columns, this.unique);
return typeof this.name === 'object' ? new IndexBuilder({
...this.name,
columns,
}) : new IndexBuilder(this.name, columns, this.unique);
}
}

Expand All @@ -54,10 +66,13 @@ export class IndexBuilder implements AnyIndexBuilder {
/** @internal */
config: IndexConfig;

constructor(name: string, columns: IndexColumn[], unique: boolean) {
this.config = {
constructor(name: string, columns: IndexColumn[], unique: boolean);
constructor(config: IndexConfig);

constructor(name: string | IndexConfig, columns?: IndexColumn[], unique?: boolean) {
typeof name === 'object' ? this.config = name : this.config = {
name,
columns,
columns: columns as IndexColumn[],
unique,
};
}
Expand Down Expand Up @@ -106,3 +121,7 @@ export function index(name: string): IndexBuilderOn {
export function uniqueIndex(name: string): IndexBuilderOn {
return new IndexBuilderOn(name, true);
}

export function vectorIndex(config: Omit<IndexConfig, 'columns' | 'vector'>): IndexBuilderOn {
return new IndexBuilderOn({ ...config, vector: true }, false);
}