[Pg]: add array keyword support #3782
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if a raw sql string was used with the ARRAY keyword definition the `defaultForColumn` function would not know how to parse it. Now the `defaultForColumn` function will return early if the ARRAY definition is used
tscritch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2861 and #2904
Previously if a raw sql string was used with the ARRAY keyword definition the
defaultForColumnfunction would not know how to parse it. Now thedefaultForColumnfunction will return early if the ARRAY definition is used.I chose jsonb column type in the test as it was a slightly more complicated scenario than just text or other column type.